From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752704AbcI1GKN (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Sep 2016 02:10:13 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:52645 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751696AbcI1GKM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Sep 2016 02:10:12 -0400
Date: Wed, 28 Sep 2016 08:10:16 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Kilgore <mattkilgore12@gmail.com>
Cc: namrataashettar@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes: 3d44a78f0d8b ("staging: rtl8712: Remove
 unnecessary 'else'")
Message-ID: <20160928061016.GA2841@kroah.com>
References: <20160928030754.GA5457@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160928030754.GA5457@gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2016 at 11:07:54PM -0400, Matthew Kilgore wrote:
> An "unnecessary" 'else' was removed due to complains from checkpatch.pl
> as it is preceded by a 'return', however the 'else' branch is necessary
> as an earlier branch of the 'if' falls through. By removing the 'else',
> that route now hits the 'break' and the 'while' loop exits prematurely.
> 
> This commit reverts that change and puts the original 'else' back in
> place.

Ugh, good catch, sorry for missing this, my fault.

greg k-h