From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750970AbcI1G4U (ORCPT ); Wed, 28 Sep 2016 02:56:20 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42714 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbcI1G4O (ORCPT ); Wed, 28 Sep 2016 02:56:14 -0400 Date: Wed, 28 Sep 2016 08:56:02 +0200 From: Peter Zijlstra To: Vineet Gupta Cc: Kim Phillips , Nicolas Pitre , Petr Mladek , Kees Cook , Arnd Bergmann , Ard Biesheuvel , Alexey Brodkin , linux-kernel@vger.kernel.org, Johannes Weiner , Tejun Heo , Andrew Morton , linux-snps-arc@lists.infradead.org, Thomas Garnier Subject: Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Message-ID: <20160928065602.GS2794@worktop> References: <1474988036-22260-1-git-send-email-vgupta@synopsys.com> <20160927113727.55dc9dcf23880a63105da670@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 09:51:35AM -0700, Vineet Gupta wrote: > On 09/27/2016 09:37 AM, Kim Phillips wrote: > > On Tue, 27 Sep 2016 07:53:56 -0700 > > Vineet Gupta wrote: > > > >> > This doesn't seem to be used anywhere > > I thought so too, until I got this response for an equivalent patch: > > > > https://lkml.org/lkml/2016/8/31/53 > > So this is some sort of "developer shortcut" to quickly enable 2 options with one > option. Purpose seems dubious to me ! It would still be possible to enable vmalloc > backed mmap on x86 by simply enabling that option from Kconfig. PERF_USE_VMALLOC is not a user selectable option. Also DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck, even the help text says what its for.