From: Peter Zijlstra <peterz@infradead.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: arcml <linux-snps-arc@lists.infradead.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
lkml <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: NMI for ARC
Date: Wed, 28 Sep 2016 09:16:42 +0200 [thread overview]
Message-ID: <20160928071642.GU2794@worktop> (raw)
In-Reply-To: <3b23d64c-2579-b72e-645a-e7ece3c1a3c6@synopsys.com>
On Tue, Sep 27, 2016 at 05:22:13PM -0700, Vineet Gupta wrote:
> > Yeah, Sparc64 might be a better example, it more closely matches your
> > hardware. See
> > arch/sparc/include/asm/irqflags_64.h:arch_local_irq_save().
>
> So I finally got around to doing this and as expected has turned out to be quite
> some fun. I have a couple of questions and would really appreciate your inputs there.
>
> 1. Is it OK in general to short-circuit preemption off irq checks for NMI style
> interrupts.
Yes. If the NMI returns to kernel space you must not attempt preemption
for reasons you found :-), if the NMI returns to userspace you should do
the normal return to user bits, I think.
> 2. The low level return code, resume_user_mode_begin and/or resume_kernel_mode
> require interrupt safety, does that need to be NMI safe as well. We ofcourse want
> the very late register restore parts to be non-interruptible, but is this required
> before we call prrempt_schedule_irq() off of asm code.
Urgh, I'm never quite sure on the details here, I've Cc'ed Andy who
might actually know this off the top of his head. I'll try and dig
through x86 to see what it does.
next prev parent reply other threads:[~2016-09-28 7:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1445286926.3913.13.camel@synopsys.com>
2015-11-17 9:14 ` local64_cmpxchg() in arc_perf_event_update() Vineet Gupta
2015-11-17 11:07 ` Peter Zijlstra
2015-11-17 11:23 ` Vineet Gupta
2015-11-17 12:24 ` Peter Zijlstra
2015-11-17 12:25 ` Peter Zijlstra
2015-11-17 12:53 ` NMI for ARC Vineet Gupta
2015-11-17 13:15 ` Peter Zijlstra
2016-09-28 0:22 ` Vineet Gupta
2016-09-28 7:16 ` Peter Zijlstra [this message]
2016-09-28 17:58 ` Vineet Gupta
2016-09-28 19:25 ` Andy Lutomirski
2016-09-28 20:37 ` Peter Zijlstra
2016-09-28 22:26 ` Andy Lutomirski
2016-09-28 22:44 ` Vineet Gupta
2016-09-28 22:47 ` Andy Lutomirski
2016-09-29 1:20 ` Vineet Gupta
2016-09-29 6:43 ` Peter Zijlstra
2016-09-29 16:47 ` Vineet Gupta
2016-09-29 18:54 ` Andy Lutomirski
2016-09-29 19:48 ` Vineet Gupta
2016-09-30 10:49 ` Peter Zijlstra
2016-09-29 17:30 ` Andy Lutomirski
2015-11-17 13:24 ` local64_cmpxchg() in arc_perf_event_update() Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928071642.GU2794@worktop \
--to=peterz@infradead.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=luto@amacapital.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox