From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbcI1J1z (ORCPT ); Wed, 28 Sep 2016 05:27:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58110 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbcI1J1i (ORCPT ); Wed, 28 Sep 2016 05:27:38 -0400 Date: Wed, 28 Sep 2016 11:27:41 +0200 From: Greg KH To: Zach Brown Cc: f.fainelli@gmail.com, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net, mlindner@marvell.com Subject: Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace Message-ID: <20160928092741.GA16646@kroah.com> References: <1475013111-18942-1-git-send-email-zach.brown@ni.com> <1475013111-18942-3-git-send-email-zach.brown@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475013111-18942-3-git-send-email-zach.brown@ni.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote: > Adding led support for phy causes namespace conflicts for some > phy drivers. > > The rtl871 driver declared an enum for representing LED states. The enum > contains constant LED_OFF which conflicted with declaration found in > linux/leds.h. LED_OFF changed to LED_STATE_OFF > In order to avoid a possible future collision LED_ON was changed to > LED_STATE_ON as well. > > Signed-off-by: Zach Brown > --- > drivers/staging/rtl8712/rtl8712_led.c | 388 +++++++++++++++++----------------- > 1 file changed, 194 insertions(+), 194 deletions(-) Ick, messy. I'll be glad to take this patch now to make your life easier in the future. thanks, greg k-h