From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754031AbcI1JfI (ORCPT ); Wed, 28 Sep 2016 05:35:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753031AbcI1Je5 (ORCPT ); Wed, 28 Sep 2016 05:34:57 -0400 Date: Wed, 28 Sep 2016 11:34:59 +0200 From: Greg KH To: Martin Alonso Cc: joe@perches.com, forest@alittletooquiet.net, pasteka@kabsi.at, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Message-ID: <20160928093459.GA392@kroah.com> References: <20160927165901.GA28955@malonso-pc> <1474998769-29646-1-git-send-email-martin.alonso@zoho.com> <1474998769-29646-2-git-send-email-martin.alonso@zoho.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474998769-29646-2-git-send-email-martin.alonso@zoho.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote: > Change the type and uses of rx_rate. That's totally vague and doesn't say why this patch is needed at all. For all I can tell, it looks like you are changing the type for no good reason... Please fix this up and resend. thanks, greg k-h