From: Greg KH <gregkh@linuxfoundation.org>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
noralf@tronnes.org
Subject: Re: [PATCH] staging: fbtft: Fix checkpatch warning
Date: Wed, 28 Sep 2016 12:05:32 +0200 [thread overview]
Message-ID: <20160928100532.GA9499@kroah.com> (raw)
In-Reply-To: <20160928095946.845-1-palminha@synopsys.com>
On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote:
> Improve code readability.
You are doing multiple things in the same patch, and you don't really
tell us what you are doing, or why you are doing it...
Please take a step back, relax, and wait a day before resending a patch
series for these issues.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-28 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:59 [PATCH] staging: fbtft: Fix checkpatch warning Carlos Palminha
2016-09-28 10:05 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-24 9:02 [PATCH] Staging: " Anar Adilova
2017-03-27 12:06 ` Greg KH
2016-09-28 9:43 [PATCH] staging: " Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928100532.GA9499@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox