From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbcI1KFi (ORCPT ); Wed, 28 Sep 2016 06:05:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58487 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbcI1KF3 (ORCPT ); Wed, 28 Sep 2016 06:05:29 -0400 Date: Wed, 28 Sep 2016 12:05:32 +0200 From: Greg KH To: Carlos Palminha Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, noralf@tronnes.org Subject: Re: [PATCH] staging: fbtft: Fix checkpatch warning Message-ID: <20160928100532.GA9499@kroah.com> References: <20160928095946.845-1-palminha@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160928095946.845-1-palminha@synopsys.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote: > Improve code readability. You are doing multiple things in the same patch, and you don't really tell us what you are doing, or why you are doing it... Please take a step back, relax, and wait a day before resending a patch series for these issues. thanks, greg k-h