Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

Florian Vaussard
2016-09-28T10:04:49Z

Hello Jacek,

Le 24. 09. 16 à 21:06, Jacek Anaszewski a écrit :
> On 09/24/2016 01:58 PM, Pavel Machek wrote:
>> Hi!
>>
>>> +Example
>>> +=======
>>> +
>>> +led1: ncp5623@38 {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + compatible = "onnn,ncp5623";
>>> + reg = <0x38>;
>>> + onnn,led-iref-microamp = <10>;
>>> +
>>> + led1r@0 {
>>> + label = "ncp:power:red";
>>> + linux,default-trigger = "default-on";
>> ...
>>> + led1b@1 {
>>> + label = "ncp:power:blue";
>>> + reg = <1>;
>>
>> Actually... the three LEDs are packaged such as this is one colorful
>> light to the user, right? Some day we'll need to group them, so that
>> kernel can automatically tell this is one led, and probably add extra
>> attributes, such as values that produce white light.
>
> We could try out the trigger approach we discussed few months ago.
> Unfortunately I currently don't have enough time to propose the
> implementation. Probably this work could be done on the occasion of
> addition of RGB LED class driver like this, if the author had free
> bandwidth for that.
>

Unfortunately my bandwidth is pretty well used at the moment :)

Best regards,
Florian