public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: shyam saini <mayhs11saini@gmail.com>
Cc: labbott@redhat.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, arve@android.com,
	sumit.semwal@linaro.org
Subject: Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style
Date: Wed, 28 Sep 2016 14:09:31 +0200	[thread overview]
Message-ID: <20160928120931.GA18729@kroah.com> (raw)
In-Reply-To: <1475058332-15817-1-git-send-email-mayhs11saini@gmail.com>

On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form and
> fixed switch case indentation issue.

If you need "and" in a subject: line for a patch, that's a huge hint
that this needs to be at least 2 patches.

Please only ever do "one type of thing" in a single patch.  And no, that
one thing can not be "fix all coding style issues" :)

Please break this up into multiple patches and resend it.

thanks,

greg k-h

      reply	other threads:[~2016-09-28 12:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 10:25 [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style shyam saini
2016-09-28 12:09 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928120931.GA18729@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mayhs11saini@gmail.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox