From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbcI1MJg (ORCPT ); Wed, 28 Sep 2016 08:09:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60996 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbcI1MJ3 (ORCPT ); Wed, 28 Sep 2016 08:09:29 -0400 Date: Wed, 28 Sep 2016 14:09:31 +0200 From: Greg KH To: shyam saini Cc: labbott@redhat.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arve@android.com, sumit.semwal@linaro.org Subject: Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style Message-ID: <20160928120931.GA18729@kroah.com> References: <1475058332-15817-1-git-send-email-mayhs11saini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475058332-15817-1-git-send-email-mayhs11saini@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form and > fixed switch case indentation issue. If you need "and" in a subject: line for a patch, that's a huge hint that this needs to be at least 2 patches. Please only ever do "one type of thing" in a single patch. And no, that one thing can not be "fix all coding style issues" :) Please break this up into multiple patches and resend it. thanks, greg k-h