* [PATCH v2] Staging: android: fix permissions style
@ 2016-09-28 13:23 Ramiro Oliveira
2016-09-28 13:26 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ramiro Oliveira @ 2016-09-28 13:23 UTC (permalink / raw)
To: gregkh, arve, riandrews, devel, linux-kernel; +Cc: joe, Ramiro Oliveira
Change permissions from symbolic to octal.
V2: Fix all the permissions, previous patch was missing some.
Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
---
drivers/staging/android/lowmemorykiller.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index 80d7adf..553a3ee 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -204,10 +204,10 @@ device_initcall(lowmem_init);
* not really modular, but the easiest way to keep compat with existing
* bootargs behaviour is to continue using module_param here.
*/
-module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
+module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
- S_IRUGO | S_IWUSR);
+ 0644);
module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
- S_IRUGO | S_IWUSR);
-module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
+ 0644);
+module_param_named(debug_level, lowmem_debug_level, uint, 0644);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: android: fix permissions style
2016-09-28 13:23 [PATCH v2] Staging: android: fix permissions style Ramiro Oliveira
@ 2016-09-28 13:26 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-09-28 13:26 UTC (permalink / raw)
To: Ramiro Oliveira; +Cc: arve, riandrews, devel, linux-kernel, joe
On Wed, Sep 28, 2016 at 02:23:00PM +0100, Ramiro Oliveira wrote:
> Change permissions from symbolic to octal.
>
> V2: Fix all the permissions, previous patch was missing some.
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
> drivers/staging/android/lowmemorykiller.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> index 80d7adf..553a3ee 100644
> --- a/drivers/staging/android/lowmemorykiller.c
> +++ b/drivers/staging/android/lowmemorykiller.c
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
> * not really modular, but the easiest way to keep compat with existing
> * bootargs behaviour is to continue using module_param here.
> */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
> - S_IRUGO | S_IWUSR);
> + 0644);
> module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
> - S_IRUGO | S_IWUSR);
> -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
> + 0644);
> +module_param_named(debug_level, lowmem_debug_level, uint, 0644);
>
Still doesn't apply, make sure you always work against linux-next...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-28 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-28 13:23 [PATCH v2] Staging: android: fix permissions style Ramiro Oliveira
2016-09-28 13:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox