From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932609AbcI1N0l (ORCPT ); Wed, 28 Sep 2016 09:26:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33685 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932362AbcI1N0f (ORCPT ); Wed, 28 Sep 2016 09:26:35 -0400 Date: Wed, 28 Sep 2016 15:26:38 +0200 From: Greg KH To: Ramiro Oliveira Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH v2] Staging: android: fix permissions style Message-ID: <20160928132638.GA26551@kroah.com> References: <486aa341c6a3d5bc5ce155ceaeb6261b2c330fbe.1475060159.git.roliveir@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <486aa341c6a3d5bc5ce155ceaeb6261b2c330fbe.1475060159.git.roliveir@synopsys.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2016 at 02:23:00PM +0100, Ramiro Oliveira wrote: > Change permissions from symbolic to octal. > > V2: Fix all the permissions, previous patch was missing some. > Signed-off-by: Ramiro Oliveira > --- > drivers/staging/android/lowmemorykiller.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > index 80d7adf..553a3ee 100644 > --- a/drivers/staging/android/lowmemorykiller.c > +++ b/drivers/staging/android/lowmemorykiller.c > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); > * not really modular, but the easiest way to keep compat with existing > * bootargs behaviour is to continue using module_param here. > */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > - S_IRUGO | S_IWUSR); > + 0644); > module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, > - S_IRUGO | S_IWUSR); > -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); > + 0644); > +module_param_named(debug_level, lowmem_debug_level, uint, 0644); > Still doesn't apply, make sure you always work against linux-next... thanks, greg k-h