public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: lizefan@huawei.com, linux-kernel@vger.kernel.org,
	pi3orama@163.com, Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf tools: Fix building in 32 bit platform
Date: Wed, 28 Sep 2016 10:39:01 -0300	[thread overview]
Message-ID: <20160928133901.GQ5588@kernel.org> (raw)
In-Reply-To: <1475035126-146587-1-git-send-email-wangnan0@huawei.com>

Em Wed, Sep 28, 2016 at 03:58:46AM +0000, Wang Nan escreveu:
> On ARM32 building it report following error:
> 
> util/data-convert-bt.c: In function 'add_bpf_output_values':
> util/data-convert-bt.c:440:3: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format]
> cc1: all warnings being treated as errors
> 
> Fix it by changing %lu to %zu.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/data-convert-bt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 4f979bb..7123f4d 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -437,7 +437,7 @@ add_bpf_output_values(struct bt_ctf_event_class *event_class,
>  	int ret;
>  
>  	if (nr_elements * sizeof(u32) != raw_size)
> -		pr_warning("Incorrect raw_size (%u) in bpf output event, skip %lu bytes\n",
> +		pr_warning("Incorrect raw_size (%u) in bpf output event, skip %zu bytes\n",
>  			   raw_size, nr_elements * sizeof(u32) - raw_size);
>  
>  	len_type = bt_ctf_event_class_get_field_by_name(event_class, "raw_len");
> -- 
> 1.8.3.4

  reply	other threads:[~2016-09-28 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28  3:58 [PATCH] perf tools: Fix building in 32 bit platform Wang Nan
2016-09-28 13:39 ` Arnaldo Carvalho de Melo [this message]
2016-09-29 18:11 ` [tip:perf/core] perf data: Fix building in 32 bit platform with libbabeltrace tip-bot for Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928133901.GQ5588@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox