[PATCH] Staging: android: fix permissions style

[PATCH] Staging: android: fix permissions style

[Ramiro Oliveira]

Change permissions from symbolic to octal.

Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
---
 drivers/staging/android/lowmemorykiller.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index 80d7adf..03b5765 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -204,10 +204,10 @@ device_initcall(lowmem_init);
  * not really modular, but the easiest way to keep compat with existing
  * bootargs behaviour is to continue using module_param here.
  */
-module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
+module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
 module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
 			 S_IRUGO | S_IWUSR);
 module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
 			 S_IRUGO | S_IWUSR);
-module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
+module_param_named(debug_level, lowmem_debug_level, uint, 0644);

--
2.9.3

Re: [PATCH] Staging: android: fix permissions style

[Joe Perches]

On Mon, 2016-09-26 at 22:02 +0100, Ramiro Oliveira wrote:
> Change permissions from symbolic to octal.
[]
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
>   * not really modular, but the easiest way to keep compat with existing
>   * bootargs behaviour is to continue using module_param here.
>   */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
>  module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
> >  			 S_IRUGO | S_IWUSR);
>  module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
>  			 S_IRUGO | S_IWUSR);

Seems odd to fix the other two but not this one.

> -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
> +module_param_named(debug_level, lowmem_debug_level, uint, 0644);

Re: [PATCH] Staging: android: fix permissions style

[Greg KH]

On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote:
> Change permissions from symbolic to octal.
> 
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
>  drivers/staging/android/lowmemorykiller.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Doesn't apply to my tree at all, are you sure you are working against
linux-next?

thanks,

greg k-h

Re: [PATCH] Staging: android: fix permissions style

[Ramiro Oliveira]

On 9/28/2016 10:28 AM, Greg KH wrote:
> On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote:
>> Change permissions from symbolic to octal.
>>
>> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
>> ---
>>  drivers/staging/android/lowmemorykiller.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> Doesn't apply to my tree at all, are you sure you are working against
> linux-next?
>
> thanks,
>
> greg k-h

Hi Greg,

I've checked and I'm working with linux-next from September 28.

I've even cloned a fresh repository and applied my patch against it, and it didn't return any error.

I'm following this man page: https://www.kernel.org/doc/man-pages/linux-next.html

And these are the latest commits I can see in my local repository.

ramiro (28-Set) ~/linux-next $ git log --pretty=oneline --abbrev-commit -10
486aa34 Staging: android: fix permissions style
d1dfecd Add linux-next specific files for 20160928
193fc13 Merge branch 'akpm/master'
0a02a3c treewide: remove redundant #include <linux/kconfig.h>
8cac28f hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix
25758d2 hung_task: allow hung_task_panic when hung_task_warnings is 0
ceed084 kthread: add kerneldoc for kthread_create()
998139d scripts/tags.sh: enable code completion in VIM
b6edcec mm: kmemleak: avoid using __va() on addresses that don't have a lowmem mapping
73ac410 kdump, vmcoreinfo: report memory sections virtual addresses

Can you give some pointers on what I might be doing wrong?

BRs,
Ramiro

Re: [PATCH] Staging: android: fix permissions style

[Greg KH]

On Wed, Sep 28, 2016 at 02:48:39PM +0100, Ramiro Oliveira wrote:
> On 9/28/2016 10:28 AM, Greg KH wrote:
> > On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote:
> >> Change permissions from symbolic to octal.
> >>
> >> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> >> ---
> >>  drivers/staging/android/lowmemorykiller.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> > Doesn't apply to my tree at all, are you sure you are working against
> > linux-next?
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> 
> I've checked and I'm working with linux-next from September 28.
> 
> I've even cloned a fresh repository and applied my patch against it, and it didn't return any error.
> 
> I'm following this man page: https://www.kernel.org/doc/man-pages/linux-next.html
> 
> And these are the latest commits I can see in my local repository.
> 
> ramiro (28-Set) ~/linux-next $ git log --pretty=oneline --abbrev-commit -10
> 486aa34 Staging: android: fix permissions style
> d1dfecd Add linux-next specific files for 20160928
> 193fc13 Merge branch 'akpm/master'
> 0a02a3c treewide: remove redundant #include <linux/kconfig.h>
> 8cac28f hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix
> 25758d2 hung_task: allow hung_task_panic when hung_task_warnings is 0
> ceed084 kthread: add kerneldoc for kthread_create()
> 998139d scripts/tags.sh: enable code completion in VIM
> b6edcec mm: kmemleak: avoid using __va() on addresses that don't have a lowmem mapping
> 73ac410 kdump, vmcoreinfo: report memory sections virtual addresses
> 
> Can you give some pointers on what I might be doing wrong?

Hm, I think this is my fault, sorry.  The patch that this conflicts with
was applied by me yesterday, and didn't make it into linux-next for the
release that you are using.

Sorry about that.  You can wait for the next linux-next release
tomorrow, or you can work off my staging-next branch of the staging.git
tree on git.kernel.org (that branch ends up in linux-next.)

So you were doing the right thing, we just got out of sync.

greg k-h

Re: [PATCH] Staging: android: fix permissions style

[Ramiro Oliveira]

On 9/28/2016 4:37 PM, Greg KH wrote:
> On Wed, Sep 28, 2016 at 02:48:39PM +0100, Ramiro Oliveira wrote:
>> On 9/28/2016 10:28 AM, Greg KH wrote:
>>> On Mon, Sep 26, 2016 at 10:02:28PM +0100, Ramiro Oliveira wrote:
>>>> Change permissions from symbolic to octal.
>>>>
>>>> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
>>>> ---
>>>>  drivers/staging/android/lowmemorykiller.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>> Doesn't apply to my tree at all, are you sure you are working against
>>> linux-next?
>>>
>>> thanks,
>>>
>>> greg k-h
>> Hi Greg,
>>
>> I've checked and I'm working with linux-next from September 28.
>>
>> I've even cloned a fresh repository and applied my patch against it, and it didn't return any error.
>>
>> I'm following this man page: https://www.kernel.org/doc/man-pages/linux-next.html
>>
>> And these are the latest commits I can see in my local repository.
>>
>> ramiro (28-Set) ~/linux-next $ git log --pretty=oneline --abbrev-commit -10
>> 486aa34 Staging: android: fix permissions style
>> d1dfecd Add linux-next specific files for 20160928
>> 193fc13 Merge branch 'akpm/master'
>> 0a02a3c treewide: remove redundant #include <linux/kconfig.h>
>> 8cac28f hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix
>> 25758d2 hung_task: allow hung_task_panic when hung_task_warnings is 0
>> ceed084 kthread: add kerneldoc for kthread_create()
>> 998139d scripts/tags.sh: enable code completion in VIM
>> b6edcec mm: kmemleak: avoid using __va() on addresses that don't have a lowmem mapping
>> 73ac410 kdump, vmcoreinfo: report memory sections virtual addresses
>>
>> Can you give some pointers on what I might be doing wrong?
> Hm, I think this is my fault, sorry.  The patch that this conflicts with
> was applied by me yesterday, and didn't make it into linux-next for the
> release that you are using.
>
> Sorry about that.  You can wait for the next linux-next release
> tomorrow, or you can work off my staging-next branch of the staging.git
> tree on git.kernel.org (that branch ends up in linux-next.)
>
> So you were doing the right thing, we just got out of sync.
>
> greg k-h
Thanks for the feedback. I'll work against your staging-next branch and submit
the corrected patch.

BRs,
Ramiro