* [PATCH 1/1] Staging: android: ion: Fixed coding style issues
@ 2016-09-28 15:21 shyam saini
2016-09-28 15:39 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: shyam saini @ 2016-09-28 15:21 UTC (permalink / raw)
To: labbott; +Cc: sumit.semwal, gregkh, linux-kernel, devel, arve, shyam saini
Fixed checkpatch coding style issues
Signed-off-by: shyam saini <mayhs11saini@gmail.com>
---
drivers/staging/android/ion/ion_of.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index de0899a..01f3067 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
switch (heap->type) {
- case ION_HEAP_TYPE_CARVEOUT:
- case ION_HEAP_TYPE_CHUNK:
- if (heap->base && heap->size)
- return 0;
-
- ret = of_reserved_mem_device_init(heap->priv);
- break;
- default:
- break;
+ case ION_HEAP_TYPE_CARVEOUT:
+ case ION_HEAP_TYPE_CHUNK:
+ if (heap->base && heap->size)
+ return 0;
+
+ ret = of_reserved_mem_device_init(heap->priv);
+ break;
+ default:
+ break;
}
return ret;
@@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev)
static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
{
- return;
+
}
static const struct reserved_mem_ops rmem_dma_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues
2016-09-28 15:21 [PATCH 1/1] Staging: android: ion: Fixed coding style issues shyam saini
@ 2016-09-28 15:39 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-09-28 15:39 UTC (permalink / raw)
To: shyam saini; +Cc: labbott, sumit.semwal, linux-kernel, devel, arve
On Wed, Sep 28, 2016 at 08:51:43PM +0530, shyam saini wrote:
> Fixed checkpatch coding style issues
What specific issues? Always be descriptive, look at previous patches
in the staging tree for examples.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] Staging: android: ion: Fixed coding style issues
@ 2016-09-28 16:51 shyam saini
2016-10-02 14:56 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: shyam saini @ 2016-09-28 16:51 UTC (permalink / raw)
To: labbott; +Cc: sumit.semwal, gregkh, linux-kernel, devel, arve, shyam saini
Fixed switch case indentation issue and void function return statement
issue
Signed-off-by: shyam saini <mayhs11saini@gmail.com>
---
drivers/staging/android/ion/ion_of.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index de0899a..01f3067 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
switch (heap->type) {
- case ION_HEAP_TYPE_CARVEOUT:
- case ION_HEAP_TYPE_CHUNK:
- if (heap->base && heap->size)
- return 0;
-
- ret = of_reserved_mem_device_init(heap->priv);
- break;
- default:
- break;
+ case ION_HEAP_TYPE_CARVEOUT:
+ case ION_HEAP_TYPE_CHUNK:
+ if (heap->base && heap->size)
+ return 0;
+
+ ret = of_reserved_mem_device_init(heap->priv);
+ break;
+ default:
+ break;
}
return ret;
@@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev)
static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
{
- return;
+
}
static const struct reserved_mem_ops rmem_dma_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues
2016-09-28 16:51 shyam saini
@ 2016-10-02 14:56 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-10-02 14:56 UTC (permalink / raw)
To: shyam saini; +Cc: labbott, devel, linux-kernel, arve, sumit.semwal
On Wed, Sep 28, 2016 at 10:21:16PM +0530, shyam saini wrote:
> Fixed switch case indentation issue and void function return statement
> issue
That's two different things in one patch, please break this up into two
different patches (which will let me reject one of them, see the
archives for why...)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-02 14:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-28 15:21 [PATCH 1/1] Staging: android: ion: Fixed coding style issues shyam saini
2016-09-28 15:39 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-09-28 16:51 shyam saini
2016-10-02 14:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox