Re: [PATCH v2 1/3] fs/exec: don't force writing memory access

Oleg Nesterov
2016-09-29T16:10:12Z

On 09/29, Jann Horn wrote:
>
> @@ -204,7 +204,7 @@ static struct page *get_arg_page(struct linux_binprm *bprm, unsigned long pos,
> * doing the exec and bprm->mm is the new process's mm.
> */
> ret = get_user_pages_remote(current, bprm->mm, pos, 1, write,
> - 1, &page, NULL);
> + 0, &page, NULL);

To me this looks like a reasonable cleanup regardless, FOLL_FORCE
just adds the unnecessary confusion here.

Oleg.