From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934398AbcI2R0V (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Sep 2016 13:26:21 -0400
Received: from down.free-electrons.com ([37.187.137.238]:47787 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S933853AbcI2R0L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Sep 2016 13:26:11 -0400
Date: Thu, 29 Sep 2016 14:04:45 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: Jonathan Liu <net147@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sun4i: rgb: Enable panel after controller
Message-ID: <20160929120445.GQ4189@lukather>
References: <20160921130304.3486-1-net147@gmail.com>
 <20160921210340.GI8719@lukather>
 <CANwerB2pmO7AMqmE9SMR1vFFsY5jMUALGSvtd=AvpU1=_jSHUw@mail.gmail.com>
 <20160923131626.GX8719@lukather>
 <CANwerB1PgaACukEj1jzUY-dQzbf50Em3h47KEsQu3rC3Jej=6Q@mail.gmail.com>
 <20160924201813.GE16901@lukather>
 <CAOw6vbKxJeSZYsCwVWYbVosZUK+FfBq1ytrpRUNpbH+kM6Ow6Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="8N5nZmKALFZnI1Hj"
Content-Disposition: inline
In-Reply-To: <CAOw6vbKxJeSZYsCwVWYbVosZUK+FfBq1ytrpRUNpbH+kM6Ow6Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--8N5nZmKALFZnI1Hj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote:
> As an aside, it seems like (from the diff, I haven't looked at the
> code) the bridge_pre_enable and bridge_post_disable calls are missing,
> and the enable/disable calls are in the wrong place.

Actually, I don't even think that's necessary. The atomic helpers
already call drm_bridge_pre_enable and drm_bridge_enable at the right
time. So I guess the proper fix would be to just remove the driver's
call to drm_bridge_enable.

Thanks!
Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--8N5nZmKALFZnI1Hj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJX7QNdAAoJEBx+YmzsjxAgnn4P/A+Pu2kdoigfQhbx6+RSUQbS
u9WOn27tcU1JtUVrzy1tubyctXnEckCCwDNl5sBZQUUyyEQ1vcU1MmdWZdEndVBK
Lk5z/+n3qvtXhQIaBlg7kss9uF++rJUVYwFFMQaPBnbT7dFgU44E3IJcjwp3mtR0
QTqvw0lBTu0bwlUuzH7NPXH/cXa/Ff+Up0N1qNLoFkASAI3SdAu+xecQ5q2aMpiI
XIKpwrtRGRrvJbNqBmaLlvTl9IIopWkHWiRQPiOPNzdRGPSADLSHMCeIZR9vXgbl
f2M1/Is2VNWS2YhGT1+r/SVmgqHtfWEKJs5fm5DBcKtfBYE/kE+fcp6pGsfeopmI
fX7/mT7mtcPF9Hlf8JDNgUoOaSn9tF+f8RbSunvYTqAQDRmrN9s4/vyu+ZL1pdDA
fSQTFNM67TdANEyIm1ruj8UDTG+PRZeAXMP1tfuUtGUiLJg087lOg5NjasYy6tFy
I/nkRS5stGYbFBzE1+0e0K0gBHdp7+fEbxBNvn+Gg86W08EsYsZ5dIkJJGjaEu01
FuSisehnb9+nZs7zZqJskegFZtn3m2UVc9O92g/MNSAucDNf9/XmFQc86+1Mm6Ao
Prrtes9b2O0QPB/5uTvy34+1cxwBfw9+WQhiI0k0mjXEzvLkgS3+NCBV3Gb0qknS
SCOg5OIqE1Qd6sDt12PW
=WaOL
-----END PGP SIGNATURE-----

--8N5nZmKALFZnI1Hj--