From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: praveen.vegivada@cirrus.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: arizona: Mark AIFx_TX_BCLK_RATE as readable for cs47l24
Date: Thu, 29 Sep 2016 20:54:32 +0100 [thread overview]
Message-ID: <20160929195432.GA13971@dell> (raw)
In-Reply-To: <1473772779-530-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, 13 Sep 2016, Charles Keepax wrote:
> From: Praveen Kumar Vegivada <praveen.vegivada@cirrus.com>
>
> This register is used in the AIF code but is missing from the register
> tables.
>
> Signed-off-by: Praveen Kumar Vegivada <praveen.vegivada@cirrus.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/cs47l24-tables.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied for v4.10, thanks.
> diff --git a/drivers/mfd/cs47l24-tables.c b/drivers/mfd/cs47l24-tables.c
> index f6b78aa..c090974 100644
> --- a/drivers/mfd/cs47l24-tables.c
> +++ b/drivers/mfd/cs47l24-tables.c
> @@ -292,6 +292,7 @@ static const struct reg_default cs47l24_reg_default[] = {
> { 0x00000502, 0x0000 }, /* R1282 - AIF1 Rx Pin Ctrl */
> { 0x00000503, 0x0000 }, /* R1283 - AIF1 Rate Ctrl */
> { 0x00000504, 0x0000 }, /* R1284 - AIF1 Format */
> + { 0x00000505, 0x0040 }, /* R1285 - AIF1 Tx BCLK Rate */
> { 0x00000506, 0x0040 }, /* R1286 - AIF1 Rx BCLK Rate */
> { 0x00000507, 0x1818 }, /* R1287 - AIF1 Frame Ctrl 1 */
> { 0x00000508, 0x1818 }, /* R1288 - AIF1 Frame Ctrl 2 */
> @@ -318,6 +319,7 @@ static const struct reg_default cs47l24_reg_default[] = {
> { 0x00000542, 0x0000 }, /* R1346 - AIF2 Rx Pin Ctrl */
> { 0x00000543, 0x0000 }, /* R1347 - AIF2 Rate Ctrl */
> { 0x00000544, 0x0000 }, /* R1348 - AIF2 Format */
> + { 0x00000545, 0x0040 }, /* R1349 - AIF2 Tx BCLK Rate */
> { 0x00000546, 0x0040 }, /* R1350 - AIF2 Rx BCLK Rate */
> { 0x00000547, 0x1818 }, /* R1351 - AIF2 Frame Ctrl 1 */
> { 0x00000548, 0x1818 }, /* R1352 - AIF2 Frame Ctrl 2 */
> @@ -340,6 +342,7 @@ static const struct reg_default cs47l24_reg_default[] = {
> { 0x00000582, 0x0000 }, /* R1410 - AIF3 Rx Pin Ctrl */
> { 0x00000583, 0x0000 }, /* R1411 - AIF3 Rate Ctrl */
> { 0x00000584, 0x0000 }, /* R1412 - AIF3 Format */
> + { 0x00000585, 0x0040 }, /* R1413 - AIF3 Tx BCLK Rate */
> { 0x00000586, 0x0040 }, /* R1414 - AIF3 Rx BCLK Rate */
> { 0x00000587, 0x1818 }, /* R1415 - AIF3 Frame Ctrl 1 */
> { 0x00000588, 0x1818 }, /* R1416 - AIF3 Frame Ctrl 2 */
> @@ -923,6 +926,7 @@ static bool cs47l24_readable_register(struct device *dev, unsigned int reg)
> case ARIZONA_AIF1_RX_PIN_CTRL:
> case ARIZONA_AIF1_RATE_CTRL:
> case ARIZONA_AIF1_FORMAT:
> + case ARIZONA_AIF1_TX_BCLK_RATE:
> case ARIZONA_AIF1_RX_BCLK_RATE:
> case ARIZONA_AIF1_FRAME_CTRL_1:
> case ARIZONA_AIF1_FRAME_CTRL_2:
> @@ -949,6 +953,7 @@ static bool cs47l24_readable_register(struct device *dev, unsigned int reg)
> case ARIZONA_AIF2_RX_PIN_CTRL:
> case ARIZONA_AIF2_RATE_CTRL:
> case ARIZONA_AIF2_FORMAT:
> + case ARIZONA_AIF2_TX_BCLK_RATE:
> case ARIZONA_AIF2_RX_BCLK_RATE:
> case ARIZONA_AIF2_FRAME_CTRL_1:
> case ARIZONA_AIF2_FRAME_CTRL_2:
> @@ -971,6 +976,7 @@ static bool cs47l24_readable_register(struct device *dev, unsigned int reg)
> case ARIZONA_AIF3_RX_PIN_CTRL:
> case ARIZONA_AIF3_RATE_CTRL:
> case ARIZONA_AIF3_FORMAT:
> + case ARIZONA_AIF3_TX_BCLK_RATE:
> case ARIZONA_AIF3_RX_BCLK_RATE:
> case ARIZONA_AIF3_FRAME_CTRL_1:
> case ARIZONA_AIF3_FRAME_CTRL_2:
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-09-29 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 13:19 [PATCH] mfd: arizona: Mark AIFx_TX_BCLK_RATE as readable for cs47l24 Charles Keepax
2016-09-29 19:54 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929195432.GA13971@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=praveen.vegivada@cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox