Re: [PATCH v4 10/12] dax: add struct iomap based DAX PMD support

Ross Zwisler
2016-10-06T21:34:35Z

On Mon, Oct 03, 2016 at 03:05:57PM -0600, Ross Zwisler wrote:
> On Mon, Oct 03, 2016 at 12:59:49PM +0200, Jan Kara wrote:
> > On Thu 29-09-16 16:49:28, Ross Zwisler wrote:
<>
> > > +int dax_iomap_pmd_fault(struct vm_area_struct *vma, unsigned long address,
> > > + pmd_t *pmd, unsigned int flags, struct iomap_ops *ops)
> > > +{
> > > + struct address_space *mapping = vma->vm_file->f_mapping;
> > > + unsigned long pmd_addr = address & PMD_MASK;
> > > + bool write = flags & FAULT_FLAG_WRITE;
> > > + struct inode *inode = mapping->host;
> > > + struct iomap iomap = { 0 };
> > > + int error, result = 0;
> > > + pgoff_t size, pgoff;
> > > + struct vm_fault vmf;
> > > + void *entry;
> > > + loff_t pos;
> > > +
> > > + /* Fall back to PTEs if we're going to COW */
> > > + if (write && !(vma->vm_flags & VM_SHARED)) {
> > > + split_huge_pmd(vma, pmd, address);
> > > + return VM_FAULT_FALLBACK;
> > > + }
> > > +
> > > + /* If the PMD would extend outside the VMA */
> > > + if (pmd_addr < vma->vm_start)
> > > + return VM_FAULT_FALLBACK;
> > > + if ((pmd_addr + PMD_SIZE) > vma->vm_end)
> > > + return VM_FAULT_FALLBACK;
> > > +
> > > + /*
> > > + * Check whether offset isn't beyond end of file now. Caller is
> > > + * supposed to hold locks serializing us with truncate / punch hole so
> > > + * this is a reliable test.
> > > + */
> > > + pgoff = linear_page_index(vma, pmd_addr);
> > > + size = (i_size_read(inode) + PAGE_SIZE - 1) >> PAGE_SHIFT;
> > > +
> > > + if (pgoff >= size)
> > > + return VM_FAULT_SIGBUS;
> > > +
> > > + /* If the PMD would extend beyond the file size */
> > > + if ((pgoff | PG_PMD_COLOUR) >= size)
> > > + return VM_FAULT_FALLBACK;
> > > +
> > > + /*
> > > + * grab_mapping_entry() will make sure we get a 2M empty entry, a DAX
> > > + * PMD or a HZP entry. If it can't (because a 4k page is already in
> > > + * the tree, for instance), it will return -EEXIST and we just fall
> > > + * back to 4k entries.
> > > + */
> > > + entry = grab_mapping_entry(mapping, pgoff, RADIX_DAX_PMD);
> > > + if (IS_ERR(entry))
> > > + return VM_FAULT_FALLBACK;
> > > +
> > > + /*
> > > + * Note that we don't use iomap_apply here. We aren't doing I/O, only
> > > + * setting up a mapping, so really we're using iomap_begin() as a way
> > > + * to look up our filesystem block.
> > > + */
> > > + pos = (loff_t)pgoff << PAGE_SHIFT;
> > > + error = ops->iomap_begin(inode, pos, PMD_SIZE, write ? IOMAP_WRITE : 0,
> > > + &iomap);
> >
> > I'm not quite sure if it is OK to call ->iomap_begin() without ever calling
> > ->iomap_end. Specifically the comment before iomap_apply() says:
> >
> > "It is assumed that the filesystems will lock whatever resources they
> > require in the iomap_begin call, and release them in the iomap_end call."
> >
> > so what you do could result in unbalanced allocations / locks / whatever.
> > Christoph?
>
> I'll add the iomap_end() calls to both the PTE and PMD iomap fault handlers.

Interesting - adding iomap_end() calls to the DAX PTE fault handler causes an
AA deadlock because we try and retake ei->dax_sem. We take dax_sem in
ext2_dax_fault() before calling into the DAX code, then if we end up going
through the error path in ext2_iomap_end(), we call
ext2_write_failed()
ext2_truncate_blocks()
dax_sem_down_write()

Where we try and take dax_sem again. This error path is really only valid for
I/O operations, but we happen to call it for page faults because 'written' in
ext2_iomap_end() is just 0.

So...how should we handle this? A few ideas:

1) Just continue to omit the calls to iomap_end() in the DAX page fault
handlers for now, and add them when there is useful work to be done in one of
the filesystems.

2) Add an IOMAP_FAULT flag to the flags passed into iomap_begin() and
iomap_end() so make it explicit that we are calling as part of a fault handler
and not an I/O operation, and use this to adjust the error handling in
ext2_iomap_end().

3) Just work around the existing error handling in ext2_iomap_end() by either
unsetting IOMAP_WRITE or by setting 'written' to the size of the fault.

For #2 or #3, probably add a comment explaining the deadlock and why we need
to never call ext2_write_failed() while handling a page fault.

Thoughts?