From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933479AbcI3Rkv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 30 Sep 2016 13:40:51 -0400
Received: from mga14.intel.com ([192.55.52.115]:43580 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932430AbcI3Rkg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Sep 2016 13:40:36 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,273,1473145200"; 
   d="scan'208";a="15071375"
Date: Fri, 30 Sep 2016 23:19:11 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
        Dan Williams <dan.j.williams@intel.com>,
        linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] dmaengine: coh901318: fix integer overflow when
 shifting more than 32 places
Message-ID: <20160930174911.GW2467@localhost>
References: <20160929181438.14374-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160929181438.14374-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 29, 2016 at 07:14:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
> be more than 32 places, which leads to a 32 bit integer overflow. Fix this
> by using 1ULL instead of 1 before shifting it.  Also add braces on the
> for-loop to keep with coding style conventions.

Applied, thanks

-- 
~Vinod