From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933497AbcI3RoX (ORCPT ); Fri, 30 Sep 2016 13:44:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:46059 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932887AbcI3RoQ (ORCPT ); Fri, 30 Sep 2016 13:44:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,273,1473145200"; d="scan'208";a="15487751" Date: Fri, 30 Sep 2016 23:22:50 +0530 From: Vinod Koul To: Colin King Cc: Zubair Lutfullah Kakakhel , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: jz4780: fix resource leaks on error exit return Message-ID: <20160930175250.GY2467@localhost> References: <20160929174505.13913-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160929174505.13913-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2016 at 06:45:05PM +0100, Colin King wrote: > From: Colin Ian King > > In two cases when jz4780_dma_setup_hwdesc fails, there is a memory > leak on the allocated desc and associated DMA pools on the error > exit return path. Fix this by free'ing the resources before > returning. Applied, thanks -- ~Vinod