From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbcI3Xw5 (ORCPT ); Fri, 30 Sep 2016 19:52:57 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34761 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcI3Xwy (ORCPT ); Fri, 30 Sep 2016 19:52:54 -0400 Date: Fri, 30 Sep 2016 16:52:49 -0700 From: Dmitry Torokhov To: Benjamin Tissoires Cc: KT Liao , Adrian Alves , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] Input: elan_i2c - always output the device information Message-ID: <20160930235249.GA1680@dtor-ws> References: <1475073244-23068-1-git-send-email-benjamin.tissoires@redhat.com> <1475073244-23068-3-git-send-email-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475073244-23068-3-git-send-email-benjamin.tissoires@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2016 at 04:34:02PM +0200, Benjamin Tissoires wrote: > it's always easier to retrieve these information in bug reports when > it is always printed in the dmesg. > > Signed-off-by: Benjamin Tissoires > --- > drivers/input/mouse/elan_i2c_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c > index d15b338..2de1f75 100644 > --- a/drivers/input/mouse/elan_i2c_core.c > +++ b/drivers/input/mouse/elan_i2c_core.c > @@ -1093,7 +1093,7 @@ static int elan_probe(struct i2c_client *client, > if (error) > return error; > > - dev_dbg(&client->dev, > + dev_info(&client->dev, > "Elan Touchpad Information:\n" > " Module product ID: 0x%04x\n" > " Firmware Version: 0x%04x\n" The format is acceptable for dev_dbg, but this multi-line output is not too nice for normal logging, especially as we probe the device asynchronously so there can easily be more output from other kernel threads. Thanks. -- Dmitry