From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()
Date: Sat, 1 Oct 2016 05:40:58 +0200 [thread overview]
Message-ID: <201610010540.58123.arnd@arndb.de> (raw)
In-Reply-To: <16139.1475279560@warthog.procyon.org.uk>
On Saturday 01 October 2016, David Howells wrote:
> commit 35510eefc29e2757c1ac46218cded2e505093fc2
> Author: David Howells <dhowells@redhat.com>
> Date: Sat Oct 1 00:35:15 2016 +0100
>
> rxrpc: Split rxrpc_send_call_packet()
>
> Split rxrpc_send_data_packet() to separate ACK generation (which is more
> complicated) from ABORT generation. This simplifies the code a bit and
> avoids the following warning:
>
> In file included from ../net/rxrpc/output.c:20:0:
> net/rxrpc/output.c: In function 'rxrpc_send_call_packet':
> net/rxrpc/ar-internal.h:1187:27: error: 'top' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> net/rxrpc/output.c:103:24: note: 'top' was declared here
> net/rxrpc/output.c:225:25: error: 'hard_ack' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: David Howells <dhowells@redhat.com>
Yes, good idea. We could probably share the part of the two functions that sets the
contents of the msg and pkt variables by moving it into a third function, but I'm
not sure if that actually improves readability or just reduces the number of lines.
Arnd
next prev parent reply other threads:[~2016-10-01 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 16:11 [PATCH] rxrpc: split up rxrpc_send_call_packet() Arnd Bergmann
2016-09-30 23:35 ` David Howells
2016-09-30 23:52 ` David Howells
2016-10-01 3:40 ` Arnd Bergmann [this message]
2016-10-01 9:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201610010540.58123.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox