From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbcJADlP (ORCPT ); Fri, 30 Sep 2016 23:41:15 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54971 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbcJADlO (ORCPT ); Fri, 30 Sep 2016 23:41:14 -0400 From: Arnd Bergmann To: David Howells Subject: Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() Date: Sat, 1 Oct 2016 05:40:58 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <12692.1475278509@warthog.procyon.org.uk> <20160930161218.4178124-1-arnd@arndb.de> <16139.1475279560@warthog.procyon.org.uk> In-Reply-To: <16139.1475279560@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201610010540.58123.arnd@arndb.de> X-Provags-ID: V03:K0:HDY4RKKk+o4apotcLz1F8wZdGmprQydlOhgg/Ry5oZpVfHJw7rd wu/KVSbubs2wVxai0g8QbufDxNyUdZG1mVGKJC83+JBYVvKHLH6Jxc/2yqEBoqCbLKFwUD3 j/W9iqbCY03eIt7p5kadHkTflfjyMJtj1eEcYkI0NrAW2lg+BAa8isMjggRZEjMOyMkJc9E N1vcot+nxoNmYBjEwDI9w== X-UI-Out-Filterresults: notjunk:1;V01:K0:fGnn01gSy0Q=:F6XlViAXzJWP7lesHHmNP6 qwy+GJv0Yhyvz6cLqMm3Z/Pi9glaW2+eFyx1r/d2Suik7nxBF/Fxu2jPqX2+PapPlVQbwoOtQ ske8tfB9tiKqQ+6O5b3koUzynKR3d2mf78/pvtShfKiYKrXVbyDj7g+vW5ttADet5k0qCJ4CE ZKUqUUwpCYIw83p3b8GpWo/EOShG7OkjTSyQkwhf3jrOv+OPO8LPwKIChndJDUA4WU03thO9c sMxYNUNA2ECbWS+gRUTQB4mkXYWDrYO9eUSXSaNzyHO4prYibhe2jGpSxARKP+4Mwj+EbG/QB ikWycsHQ6VdJCIrazSL2RscdeT2Si2giVPPqqMyjaoEIAppAjdsIhklatLjnckSSF/90C3ecy GBu6SeWtIO6QNQsUcQnCQHmgcuDmmjHJ8f1s6/ASg4cHjf0k0+YNC8h6Mcn99nTiYOkRGF7+z PBh50oxU1NX+q8ktrlxd1reLfFwQMACSq+zQC0nOQfadhpBMzLQuVek6hoVqgybVU2UqNWXvi Vk//+fQypEdCLojz7e1GGAjV2KuxJjr6SBbCXQDjyhXtqQ9R0LRa/TwOtzDm2BtzhNCzSbI6c q/2AYOqpbYbO6luwsJKo6jHuJlkDE8Hatk1eLPLfamhm9trFKb7aMVMfwckY2g+isGNlUlLSa T4nJ6vkF9Sz4V6jKxMQe8J4iU+xTEh2aNaq48GFwQJ2wciRE21Q1oQZJpIqfIQMczc6MxBsfN R4cM4n9GCIqi/b92 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 01 October 2016, David Howells wrote: > commit 35510eefc29e2757c1ac46218cded2e505093fc2 > Author: David Howells > Date: Sat Oct 1 00:35:15 2016 +0100 > > rxrpc: Split rxrpc_send_call_packet() > > Split rxrpc_send_data_packet() to separate ACK generation (which is more > complicated) from ABORT generation. This simplifies the code a bit and > avoids the following warning: > > In file included from ../net/rxrpc/output.c:20:0: > net/rxrpc/output.c: In function 'rxrpc_send_call_packet': > net/rxrpc/ar-internal.h:1187:27: error: 'top' may be used uninitialized in this function [-Werror=maybe-uninitialized] > net/rxrpc/output.c:103:24: note: 'top' was declared here > net/rxrpc/output.c:225:25: error: 'hard_ack' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > Reported-by: Arnd Bergmann > Signed-off-by: David Howells Yes, good idea. We could probably share the part of the two functions that sets the contents of the msg and pkt variables by moving it into a third function, but I'm not sure if that actually improves readability or just reduces the number of lines. Arnd