From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750969AbcJAGDu (ORCPT ); Sat, 1 Oct 2016 02:03:50 -0400 Received: from mga05.intel.com ([192.55.52.43]:48041 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcJAGDl (ORCPT ); Sat, 1 Oct 2016 02:03:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,277,1473145200"; d="scan'208";a="1059071170" Date: Sat, 1 Oct 2016 11:42:16 +0530 From: Vinod Koul To: Baoyou Xie Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH 1/3] dmaengine: virt-dma: move function declarations Message-ID: <20161001061216.GE2467@localhost> References: <1474691825-15068-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474691825-15068-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2016 at 12:37:05PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/dma/virt-dma.c:22:14: warning: no previous prototype for 'vchan_tx_submit' [-Wmissing-prototypes] > drivers/dma/virt-dma.c:52:5: warning: no previous prototype for 'vchan_tx_desc_free' [-Wmissing-prototypes] > > In fact, these two functions are incorrectly declared in a function. > > So this patch moves function declarations out of this function. Applied, thanks -- ~Vinod