From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbcJCDa6 (ORCPT ); Sun, 2 Oct 2016 23:30:58 -0400 Received: from mga07.intel.com ([134.134.136.100]:32504 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbcJCDat (ORCPT ); Sun, 2 Oct 2016 23:30:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,287,1473145200"; d="scan'208";a="1059615759" Date: Mon, 3 Oct 2016 09:09:24 +0530 From: Vinod Koul To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 05/10] dmaengine: qcom_hidma: make pending_tre_count atomic Message-ID: <20161003033923.GQ2467@localhost> References: <1475115167-5898-1-git-send-email-okaya@codeaurora.org> <1475115167-5898-6-git-send-email-okaya@codeaurora.org> <20161001061906.GG2467@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 01, 2016 at 11:19:43AM -0400, Sinan Kaya wrote: > On 10/1/2016 2:19 AM, Vinod Koul wrote: > >> Making it atomic so that it can be updated from multiple contexts. > > How is it multiple contexts? It's either existing context of MSI, not both! > > > > I was trying to mean multiple processor contexts here. The driver allocates 11 > MSI interrupts. Each MSI interrupt can be assigned to a different CPU. Then, > we have a race condition for common variables as they share the same interrupt > handler with a different cause bit. > > I will put the above description into the commit text. Sounds better :) -- ~Vinod