From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752528AbcJCLpx (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Oct 2016 07:45:53 -0400
Received: from mail.kernel.org ([198.145.29.136]:42254 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751140AbcJCLpw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2016 07:45:52 -0400
Date: Mon, 3 Oct 2016 08:45:44 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
        Wang Nan <wangnan0@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf probe: check if *ptr2 is zero and not ptr2
Message-ID: <20161003114544.GB12073@kernel.org>
References: <20161003103431.18534-1-colin.king@canonical.com>
 <20161003111919.GA12073@kernel.org>
 <57F23F71.1060509@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57F23F71.1060509@canonical.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Oct 03, 2016 at 12:22:25PM +0100, Colin Ian King escreveu:
> On 03/10/16 12:19, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Oct 03, 2016 at 11:34:31AM +0100, Colin King escreveu:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Static anaylsis with cppcheck detected an incorrect comparison:
> >> [tools/perf/util/probe-event.c:216]: (warning) Char literal compared with
> >> pointer 'ptr2'. Did you intend to dereference it?
> > 
> > What tool was used for that?
> 
> cppcheck https://github.com/danmar/cppcheck - I run it nearly daily on
> linux-next and linux

Thanks, I'll try to get it and use it before upstreaming stuff,

- Arnaldo
 
> > 
> > - Arnaldo
> >  
> >> Dereference ptr2 for the comparison to fix this.
> >>
> >> Fixes: 35726d3a4ca9 ("perf probe: Fix to cut off incompatible chars from group name")
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >> ---
> >>  tools/perf/util/probe-event.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> >> index fcfbef0..d281ae2 100644
> >> --- a/tools/perf/util/probe-event.c
> >> +++ b/tools/perf/util/probe-event.c
> >> @@ -213,7 +213,7 @@ static int convert_exec_to_group(const char *exec, char **result)
> >>  		goto out;
> >>  	}
> >>  
> >> -	for (ptr2 = ptr1; ptr2 != '\0'; ptr2++) {
> >> +	for (ptr2 = ptr1; *ptr2 != '\0'; ptr2++) {
> >>  		if (!isalnum(*ptr2) && *ptr2 != '_') {
> >>  			*ptr2 = '\0';
> >>  			break;
> >> -- 
> >> 2.9.3