public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	linux-kernel@vger.kernel.org,
	David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH RFC] xen: make it possible to disable XEN_TMEM
Date: Mon, 3 Oct 2016 10:19:14 -0400	[thread overview]
Message-ID: <20161003141914.GH20896@char.us.oracle.com> (raw)
In-Reply-To: <1475503368-22878-1-git-send-email-vkuznets@redhat.com>

On Mon, Oct 03, 2016 at 04:02:48PM +0200, Vitaly Kuznetsov wrote:
> XEN_TMEM config option has no prompt and it is enabled as module by
> default if CLEANCACHE or FRONTSWAP options are set with no way to disable
> it. The only in-tree user of the tmem interface is xen-selfballoon which

And if CONFIG_XEN=y .

> can itself be disabled so it makes sense to make it possible to disable

During boot-time with arguments.
> XEN_TMEM too. In theory, both these options could be unified under the
> XEN_SELFBALLOONING but other (out-of-tree) users of the tmem interface
> may exist and someone may want to keep them supported without enabling
> XEN_SELFBALLOONING.

I think going the route of XEN_SELFBALLOONING may be better.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> - I don't know much about tmem and its users thus RFC.
> ---
>  drivers/xen/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index f15bb3b7..0ea1df8 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -166,7 +166,7 @@ config SWIOTLB_XEN
>  	select SWIOTLB
>  
>  config XEN_TMEM
> -	tristate
> +	tristate "Transcendent Memory support for Xen"
>  	depends on !ARM && !ARM64
>  	default m if (CLEANCACHE || FRONTSWAP)
>  	help
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

  reply	other threads:[~2016-10-03 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 14:02 [PATCH RFC] xen: make it possible to disable XEN_TMEM Vitaly Kuznetsov
2016-10-03 14:19 ` Konrad Rzeszutek Wilk [this message]
2016-10-03 15:18   ` [Xen-devel] " Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003141914.GH20896@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkuznets@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox