From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbcJCOTd (ORCPT ); Mon, 3 Oct 2016 10:19:33 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44497 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbcJCOT0 (ORCPT ); Mon, 3 Oct 2016 10:19:26 -0400 Date: Mon, 3 Oct 2016 10:19:14 -0400 From: Konrad Rzeszutek Wilk To: Vitaly Kuznetsov Cc: xen-devel@lists.xenproject.org, Juergen Gross , Boris Ostrovsky , linux-kernel@vger.kernel.org, David Vrabel Subject: Re: [Xen-devel] [PATCH RFC] xen: make it possible to disable XEN_TMEM Message-ID: <20161003141914.GH20896@char.us.oracle.com> References: <1475503368-22878-1-git-send-email-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475503368-22878-1-git-send-email-vkuznets@redhat.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 03, 2016 at 04:02:48PM +0200, Vitaly Kuznetsov wrote: > XEN_TMEM config option has no prompt and it is enabled as module by > default if CLEANCACHE or FRONTSWAP options are set with no way to disable > it. The only in-tree user of the tmem interface is xen-selfballoon which And if CONFIG_XEN=y . > can itself be disabled so it makes sense to make it possible to disable During boot-time with arguments. > XEN_TMEM too. In theory, both these options could be unified under the > XEN_SELFBALLOONING but other (out-of-tree) users of the tmem interface > may exist and someone may want to keep them supported without enabling > XEN_SELFBALLOONING. I think going the route of XEN_SELFBALLOONING may be better. > > Signed-off-by: Vitaly Kuznetsov > --- > - I don't know much about tmem and its users thus RFC. > --- > drivers/xen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index f15bb3b7..0ea1df8 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -166,7 +166,7 @@ config SWIOTLB_XEN > select SWIOTLB > > config XEN_TMEM > - tristate > + tristate "Transcendent Memory support for Xen" > depends on !ARM && !ARM64 > default m if (CLEANCACHE || FRONTSWAP) > help > -- > 2.7.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel