* [PATCH] spmi: regmap: enable userspace writes
@ 2016-09-29 11:36 Kiran Gunda
2016-09-29 18:00 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Kiran Gunda @ 2016-09-29 11:36 UTC (permalink / raw)
To: Mark Brown, Greg Kroah-Hartman, Sudip Mukherjee, Kiran Gunda,
linux-kernel
Cc: sboyd, aghayal, adharmap
Being able to write to spmi registers via userspace is required
for quick debug and development. Enable it.
The regmap framework uses dev_name to create debugfs dir names.
So update the spmi devices to have proper names.
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
drivers/base/regmap/regmap-debugfs.c | 2 +-
drivers/spmi/spmi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 1ee3d40..061e771 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -259,7 +259,7 @@ static ssize_t regmap_map_read_file(struct file *file, char __user *user_buf,
count, ppos);
}
-#undef REGMAP_ALLOW_WRITE_DEBUGFS
+#define REGMAP_ALLOW_WRITE_DEBUGFS
#ifdef REGMAP_ALLOW_WRITE_DEBUGFS
/*
* This can be dangerous especially when we have clients such as
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 2b9b094..d7a0106 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -70,7 +70,7 @@ int spmi_device_add(struct spmi_device *sdev)
struct spmi_controller *ctrl = sdev->ctrl;
int err;
- dev_set_name(&sdev->dev, "%d-%02x", ctrl->nr, sdev->usid);
+ dev_set_name(&sdev->dev, "spmi%d-%02x", ctrl->nr, sdev->usid);
err = device_add(&sdev->dev);
if (err < 0) {
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: regmap: enable userspace writes
2016-09-29 11:36 [PATCH] spmi: regmap: enable userspace writes Kiran Gunda
@ 2016-09-29 18:00 ` Mark Brown
2016-09-30 5:07 ` kgunda
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2016-09-29 18:00 UTC (permalink / raw)
To: Kiran Gunda
Cc: Greg Kroah-Hartman, Sudip Mukherjee, linux-kernel, sboyd, aghayal,
adharmap
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> -#undef REGMAP_ALLOW_WRITE_DEBUGFS
> +#define REGMAP_ALLOW_WRITE_DEBUGFS
This is completely inappropriate for upstream, if you need to do
debugging on your platform you can enable this locally but enabling
random writes from userspace to any regmap device is really not a good
idea for system stablity or robustness.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: regmap: enable userspace writes
2016-09-29 18:00 ` Mark Brown
@ 2016-09-30 5:07 ` kgunda
2016-10-03 21:03 ` Stephen Boyd
0 siblings, 1 reply; 5+ messages in thread
From: kgunda @ 2016-09-30 5:07 UTC (permalink / raw)
To: Mark Brown
Cc: Greg Kroah-Hartman, Sudip Mukherjee, linux-kernel, sboyd, aghayal,
adharmap
On 2016-09-29 23:30, Mark Brown wrote:
> On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
>
>> -#undef REGMAP_ALLOW_WRITE_DEBUGFS
>> +#define REGMAP_ALLOW_WRITE_DEBUGFS
>
> This is completely inappropriate for upstream, if you need to do
> debugging on your platform you can enable this locally but enabling
> random writes from userspace to any regmap device is really not a good
> idea for system stablity or robustness.
Sure. I will remove this change and send the next version only to update
the spmi device name.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: regmap: enable userspace writes
2016-09-30 5:07 ` kgunda
@ 2016-10-03 21:03 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2016-10-03 21:03 UTC (permalink / raw)
To: kgunda
Cc: Mark Brown, Greg Kroah-Hartman, Sudip Mukherjee, linux-kernel,
aghayal, adharmap
On 09/30, kgunda@codeaurora.org wrote:
> On 2016-09-29 23:30, Mark Brown wrote:
> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> >
> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
> >
> >This is completely inappropriate for upstream, if you need to do
> >debugging on your platform you can enable this locally but enabling
> >random writes from userspace to any regmap device is really not a good
> >idea for system stablity or robustness.
>
> Sure. I will remove this change and send the next version only to update
> the spmi device name.
Why? The device name looks fine.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: regmap: enable userspace writes
@ 2016-10-06 10:10 kgunda
0 siblings, 0 replies; 5+ messages in thread
From: kgunda @ 2016-10-06 10:10 UTC (permalink / raw)
To: Stephen Boyd
Cc: Mark Brown, Greg Kroah-Hartman, Sudip Mukherjee, linux-kernel,
aghayal, adharmap
On 2016-10-04 02:33, Stephen Boyd wrote:
> On 09/30, kgunda@codeaurora.org wrote:
>> On 2016-09-29 23:30, Mark Brown wrote:
>> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
>> >
>> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
>> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
>> >
>> >This is completely inappropriate for upstream, if you need to do
>> >debugging on your platform you can enable this locally but enabling
>> >random writes from userspace to any regmap device is really not a good
>> >idea for system stablity or robustness.
>>
>> Sure. I will remove this change and send the next version only to
>> update
>> the spmi device name.
>
> Why? The device name looks fine.
Ok. I will re-check and ignore the patch, if no changes required.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-06 10:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-29 11:36 [PATCH] spmi: regmap: enable userspace writes Kiran Gunda
2016-09-29 18:00 ` Mark Brown
2016-09-30 5:07 ` kgunda
2016-10-03 21:03 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2016-10-06 10:10 kgunda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).