From: Lukas Wunner <lukas@wunner.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
Emil Velikov <emil.l.velikov@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v8 2/4] drm: Add API for capturing frame CRCs
Date: Tue, 4 Oct 2016 14:23:13 +0200 [thread overview]
Message-ID: <20161004122313.GA4832@wunner.de> (raw)
In-Reply-To: <CAKMK7uGLhpDt3hWyDG++ey=QepSyi2a8Q4PrZ=8HhETvUbQBCA@mail.gmail.com>
On Tue, Oct 04, 2016 at 01:25:23PM +0200, Daniel Vetter wrote:
> On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
> > Looks like crtc is a errno in the above case. I see this function is
> > called by looping through all the crtc and we never check to see if
> > they are valid. Should we?
nouveau is exploding as well on driver load!
> Tegra is still using the load/unload hooks. That didn't mesh well with
> Tomeu's patches (and Tomeu's patches have been thrown out meanwhile
> because of that).
They're still on drm-intel-nightly, please revert if they're broken.
Thanks,
Lukas
next prev parent reply other threads:[~2016-10-04 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 9:56 [PATCH v8 0/4] New debugfs API for capturing CRC of frames Tomeu Vizoso
2016-09-09 9:56 ` [PATCH v8 1/4] drm/i915/debugfs: Move out pipe CRC code Tomeu Vizoso
2016-09-09 9:56 ` [PATCH v8 2/4] drm: Add API for capturing frame CRCs Tomeu Vizoso
2016-10-04 10:10 ` Jon Hunter
2016-10-04 11:25 ` Daniel Vetter
2016-10-04 12:23 ` Lukas Wunner [this message]
2016-10-04 12:44 ` Lukas Wunner
2016-10-04 12:38 ` Jon Hunter
2016-09-09 9:56 ` [PATCH v8 3/4] drm/i915: Use new CRC debugfs API Tomeu Vizoso
2016-09-09 9:56 ` [PATCH v8 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004122313.GA4832@wunner.de \
--to=lukas@wunner.de \
--cc=corbet@lwn.net \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox