From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754488AbcJELFh (ORCPT ); Wed, 5 Oct 2016 07:05:37 -0400 Received: from mail.kernel.org ([198.145.29.136]:45284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbcJELFg (ORCPT ); Wed, 5 Oct 2016 07:05:36 -0400 Date: Wed, 5 Oct 2016 08:05:30 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Don Zickus , Joe Mario , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern , Andi Kleen Subject: Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Message-ID: <20161005110530.GN7143@kernel.org> References: <1474558645-19956-1-git-send-email-jolsa@kernel.org> <1474558645-19956-21-git-send-email-jolsa@kernel.org> <20161005110141.GM7143@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161005110141.GM7143@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 05, 2016 at 08:01:41AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu: > > + > > + return snprintf(hpp->buf, hpp->size, "%*s", width, hex_str(addr)); > > So here you get that static buffer and then truncate it? Wouldn't the > perf_hpp stuff take care of this? Can't we stop using that static buffer > and this truncation at such a level? So please consider continuing from what I left at the tmp.perf/c2c.2 branch in my tree, Thanks, - Arnaldo