From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754844AbcJELhR (ORCPT ); Wed, 5 Oct 2016 07:37:17 -0400 Received: from mail.kernel.org ([198.145.29.136]:50078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcJELhQ (ORCPT ); Wed, 5 Oct 2016 07:37:16 -0400 Date: Wed, 5 Oct 2016 08:37:06 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Message-ID: <20161005113706.GX7143@kernel.org> References: <20161001101700.29146-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161001101700.29146-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Oct 01, 2016 at 07:17:00PM +0900, Namhyung Kim escreveu: > When it's called with an offset less than or equal to the first event, > it'll return a garbage value since the data is not initialized. Steven, Ack? - Arnaldo > Cc: Steven Rostedt > Signed-off-by: Namhyung Kim > --- > tools/lib/traceevent/kbuffer-parse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c > index 3bcada3ae05a..65984f1c2974 100644 > --- a/tools/lib/traceevent/kbuffer-parse.c > +++ b/tools/lib/traceevent/kbuffer-parse.c > @@ -622,6 +622,7 @@ void *kbuffer_read_at_offset(struct kbuffer *kbuf, int offset, > > /* Reset the buffer */ > kbuffer_load_subbuffer(kbuf, kbuf->subbuffer); > + data = kbuffer_read_event(kbuf, ts); > > while (kbuf->curr < offset) { > data = kbuffer_next_event(kbuf, ts); > -- > 2.10.0