From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Nikolay Borisov <kernel@kyup.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Reword help of RCU_TRACE option
Date: Wed, 5 Oct 2016 07:03:07 -0700 [thread overview]
Message-ID: <20161005140307.GE3640@linux.vnet.ibm.com> (raw)
In-Reply-To: <1475651181-5512-1-git-send-email-kernel@kyup.com>
On Wed, Oct 05, 2016 at 10:06:21AM +0300, Nikolay Borisov wrote:
> Explicitly state that enabling RCU_TRACE enables more
> tracepoints and not just "additional tracing".
>
> Signed-off-by: Nikolay Borisov <kernel@kyup.com>
> ---
>
> Hello Paul,
>
> Following our latest conversation re. enabling RCU tracing
> I had to actually go and look into the code to see which
> option enables the additional tracepoints. I wasn't sure
> while reading the help of TRACE_RCU. So here is a patch
> which explicitly states that this enables additional
> tracepoints.
>
> Apply it if you deem necessary it might be just me that
> thinks the description is not verbose enough.
>
> lib/Kconfig.debug | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index cab7405f48d2..f8c3468ec7ef 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1429,8 +1429,8 @@ config RCU_TRACE
> depends on DEBUG_KERNEL
> select TRACE_CLOCK
> help
> - This option provides tracing in RCU which presents stats
> - in debugfs for debugging RCU implementation.
> + This option enables additional tracepoints in RCU which present
> + stats in debugfs for debugging RCU implementation.
How about something like this?
This option provides tracing in RCU which presents stats
in debugfs for debugging RCU implementation. It also enables
additional tracepoints for ftrace-style event tracing.
Thanx, Paul
>
> Say Y here if you want to enable RCU tracing
> Say N if you are unsure.
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-10-05 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 7:06 [PATCH] rcu: Reword help of RCU_TRACE option Nikolay Borisov
2016-10-05 14:03 ` Paul E. McKenney [this message]
2016-10-05 14:18 ` Nikolay Borisov
2016-10-06 12:45 ` Paul E. McKenney
2016-10-06 12:51 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005140307.GE3640@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=kernel@kyup.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox