* [PATCH] staging: speakup: Replaced obsolete simple_strtoul
@ 2016-10-05 20:32 Jitendra Khasdev
2016-10-05 21:11 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Jitendra Khasdev @ 2016-10-05 20:32 UTC (permalink / raw)
To: w.d.hubbs, chris, kirk, samuel.thibault, gregkh, bankarsandhya512,
saurabh.truth, amitoj1606
Cc: speakup, devel, linux-kernel, Jitendra Kumar Khasdev
From: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.
Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 21186e3..1a3caf3 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -323,9 +323,11 @@ char *spk_strlwr(char *s)
char *spk_s2uchar(char *start, char *dest)
{
- int val;
+ unsigned long val;
+
+ if (kstrtoul(start, 10, &val))
+ return NULL;
- val = simple_strtoul(skip_spaces(start), &start, 10);
if (*start == ',')
start++;
*dest = (u_char)val;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul
2016-10-05 20:32 [PATCH] staging: speakup: Replaced obsolete simple_strtoul Jitendra Khasdev
@ 2016-10-05 21:11 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2016-10-05 21:11 UTC (permalink / raw)
To: Jitendra Khasdev
Cc: w.d.hubbs, chris, kirk, gregkh, bankarsandhya512, saurabh.truth,
amitoj1606, speakup, devel, linux-kernel
Hello,
Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.
> + unsigned long val;
> +
> + if (kstrtoul(start, 10, &val))
> + return NULL;
>
> - val = simple_strtoul(skip_spaces(start), &start, 10);
> if (*start == ',')
simple_strtoul modifies start, so you can't just replace it with
kstrtoul.
Samuel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-05 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-05 20:32 [PATCH] staging: speakup: Replaced obsolete simple_strtoul Jitendra Khasdev
2016-10-05 21:11 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox