From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935036AbcJFUSO (ORCPT ); Thu, 6 Oct 2016 16:18:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934936AbcJFUSH (ORCPT ); Thu, 6 Oct 2016 16:18:07 -0400 Date: Thu, 6 Oct 2016 14:18:05 -0600 From: Alex Williamson To: Eric Auger Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, Jean-Philippe.Brucker@arm.com, yehuday@marvell.com, Manish.Jaggi@caviumnetworks.com Subject: Re: [PATCH v13 08/15] vfio: Introduce a vfio_dma type field Message-ID: <20161006141805.1ba48859@t450s.home> In-Reply-To: <1475743531-4780-9-git-send-email-eric.auger@redhat.com> References: <1475743531-4780-1-git-send-email-eric.auger@redhat.com> <1475743531-4780-9-git-send-email-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 06 Oct 2016 20:18:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Oct 2016 08:45:24 +0000 Eric Auger wrote: > We introduce a vfio_dma type since we will need to discriminate > different types of dma slots: > - VFIO_IOVA_USER: IOVA region used to map user vaddr > - VFIO_IOVA_RESERVED_MSI: IOVA region reserved to map MSI doorbells > > Signed-off-by: Eric Auger Acked-by: Alex Williamson > > --- > v9 -> v10: > - renamed VFIO_IOVA_RESERVED into VFIO_IOVA_RESERVED_MSI > - explicitly set type to VFIO_IOVA_USER on dma_map > > v6 -> v7: > - add VFIO_IOVA_ANY > - do not introduce yet any VFIO_IOVA_RESERVED handling > --- > drivers/vfio/vfio_iommu_type1.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 2ba1942..a9f8b93 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -53,6 +53,12 @@ module_param_named(disable_hugepages, > MODULE_PARM_DESC(disable_hugepages, > "Disable VFIO IOMMU support for IOMMU hugepages."); > > +enum vfio_iova_type { > + VFIO_IOVA_USER = 0, /* standard IOVA used to map user vaddr */ > + VFIO_IOVA_RESERVED_MSI, /* reserved to map MSI doorbells */ > + VFIO_IOVA_ANY, /* matches any IOVA type */ > +}; > + > struct vfio_iommu { > struct list_head domain_list; > struct mutex lock; > @@ -75,6 +81,7 @@ struct vfio_dma { > unsigned long vaddr; /* Process virtual addr */ > size_t size; /* Map size (bytes) */ > int prot; /* IOMMU_READ/WRITE */ > + enum vfio_iova_type type; /* type of IOVA */ > }; > > struct vfio_group { > @@ -607,6 +614,7 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, > dma->iova = iova; > dma->vaddr = vaddr; > dma->prot = prot; > + dma->type = VFIO_IOVA_USER; > > /* Insert zero-sized and grow as we map chunks of it */ > vfio_link_dma(iommu, dma);