From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] perf, tools: Handle completion of upper case events
Date: Thu, 6 Oct 2016 17:05:43 -0300 [thread overview]
Message-ID: <20161006200543.GE4809@kernel.org> (raw)
In-Reply-To: <1475781807-6034-2-git-send-email-andi@firstfloor.org>
Em Thu, Oct 06, 2016 at 12:23:26PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> Vendor events are often specified in upper case. perf list outputs them
> in lower case. Handle this case in perf-completion.sh so that
> completion on the upper case events still works.
Thanks, applied.
> v2: Use locale aware check for upper case
> v3: Use perf list json
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/perf-completion.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
> index 3ba80b2359cc..3b5a258a4b7b 100644
> --- a/tools/perf/perf-completion.sh
> +++ b/tools/perf/perf-completion.sh
> @@ -161,7 +161,11 @@ __perf_main ()
> # List possible events for -e option
> elif [[ $prev == @("-e"|"--event") &&
> $prev_skip_opts == @(record|stat|top) ]]; then
> - evts=$($cmd list --raw-dump)
> + # handle upper case events
> + case "$cur" in
> + [[:upper:]]*) evts=$($cmd list --raw-dump json | tr a-z A-Z) ;;
> + *) evts=$($cmd list --raw-dump) ;;
> + esac
> __perfcomp_colon "$evts" "$cur"
> else
> # List subcommands for perf commands
> --
> 2.5.5
next prev parent reply other threads:[~2016-10-06 20:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 19:23 [PATCH 1/3] perf, tools: Add support for perf list json Andi Kleen
2016-10-06 19:23 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
2016-10-06 20:05 ` Arnaldo Carvalho de Melo [this message]
2016-10-06 19:23 ` [PATCH 3/3] perf, tools: Fix completion script to handle comma list Andi Kleen
2016-10-06 20:05 ` Arnaldo Carvalho de Melo
2016-10-06 20:08 ` Andi Kleen
2016-10-06 20:29 ` Arnaldo Carvalho de Melo
2016-10-06 20:41 ` Andi Kleen
2016-10-06 20:05 ` [PATCH 1/3] perf, tools: Add support for perf list json Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2016-10-18 23:20 [PATCH 1/3] perf, tools: Add support for perf list vendor Andi Kleen
2016-10-18 23:21 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
2016-10-05 19:47 Some minor fixes for the perf tools json event code Andi Kleen
2016-10-05 19:47 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
2016-10-05 21:50 ` Arnaldo Carvalho de Melo
2016-10-05 22:18 ` Andi Kleen
2016-10-05 22:35 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006200543.GE4809@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).