From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934991AbcJFUF6 (ORCPT ); Thu, 6 Oct 2016 16:05:58 -0400 Received: from mail.kernel.org ([198.145.29.136]:56012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934742AbcJFUFv (ORCPT ); Thu, 6 Oct 2016 16:05:51 -0400 Date: Thu, 6 Oct 2016 17:05:43 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/3] perf, tools: Handle completion of upper case events Message-ID: <20161006200543.GE4809@kernel.org> References: <1475781807-6034-1-git-send-email-andi@firstfloor.org> <1475781807-6034-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475781807-6034-2-git-send-email-andi@firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Oct 06, 2016 at 12:23:26PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > Vendor events are often specified in upper case. perf list outputs them > in lower case. Handle this case in perf-completion.sh so that > completion on the upper case events still works. Thanks, applied. > v2: Use locale aware check for upper case > v3: Use perf list json > Signed-off-by: Andi Kleen > --- > tools/perf/perf-completion.sh | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh > index 3ba80b2359cc..3b5a258a4b7b 100644 > --- a/tools/perf/perf-completion.sh > +++ b/tools/perf/perf-completion.sh > @@ -161,7 +161,11 @@ __perf_main () > # List possible events for -e option > elif [[ $prev == @("-e"|"--event") && > $prev_skip_opts == @(record|stat|top) ]]; then > - evts=$($cmd list --raw-dump) > + # handle upper case events > + case "$cur" in > + [[:upper:]]*) evts=$($cmd list --raw-dump json | tr a-z A-Z) ;; > + *) evts=$($cmd list --raw-dump) ;; > + esac > __perfcomp_colon "$evts" "$cur" > else > # List subcommands for perf commands > -- > 2.5.5