From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: sukadev@linux.vnet.ibm.com, jolsa@redhat.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
wangnan0@huawei.com
Subject: Re: [PATCH 1/3] perf, tools: Handle events including .c and .o
Date: Thu, 6 Oct 2016 17:07:23 -0300 [thread overview]
Message-ID: <20161006200723.GF4809@kernel.org> (raw)
In-Reply-To: <20161006165504.GD26852@two.firstfloor.org>
Em Thu, Oct 06, 2016 at 09:55:05AM -0700, Andi Kleen escreveu:
> On Wed, Oct 05, 2016 at 07:47:06PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Oct 05, 2016 at 12:47:10PM -0700, Andi Kleen escreveu:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > This is a generic bug fix, but it helps with Sukadev's JSON event tree
> > > where such events can happen.
> > >
> > > Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading
> > > and then an error. This can happen for some Intel JSON events, which cannot
> > > be used.
> > >
> > > Fix the scanner to only match for .o or .c or .bpf at the end.
> > > This will prevent loading multiple BPF scripts separated with comma,
> > > but I assume this is acceptable.
> >
> > Wang, may I have your Acked-by, please?
>
> He acked it earlier here
>
> https://patchwork.kernel.org/patch/9337721/
>
> Tested-by: Wang Nan <wangnan0@huawei.com>
Ok, will add the example where it breaks in the commit message,
Thanks,
- Arnaldo
next prev parent reply other threads:[~2016-10-06 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 19:47 Some minor fixes for the perf tools json event code Andi Kleen
2016-10-05 19:47 ` [PATCH 1/3] perf, tools: Handle events including .c and .o Andi Kleen
2016-10-05 22:47 ` Arnaldo Carvalho de Melo
2016-10-06 16:55 ` Andi Kleen
2016-10-06 20:07 ` Arnaldo Carvalho de Melo [this message]
2016-10-06 20:18 ` Arnaldo Carvalho de Melo
2016-10-08 4:02 ` Wangnan (F)
2016-10-08 4:16 ` [PATCH] " Wang Nan
2016-10-17 14:52 ` [tip:perf/urgent] perf jevents: " tip-bot for Wang Nan
2016-10-05 19:47 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
2016-10-05 21:50 ` Arnaldo Carvalho de Melo
2016-10-05 22:18 ` Andi Kleen
2016-10-05 22:35 ` Arnaldo Carvalho de Melo
2016-10-05 19:47 ` [PATCH 3/3] perf, tools: Fix Intel fixed counter conversions Andi Kleen
2016-10-06 22:41 ` [tip:perf/urgent] perf jevents: Fix Intel JSON " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006200723.GF4809@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).