From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] perf, tools: Fix completion script to handle comma list
Date: Thu, 6 Oct 2016 17:29:44 -0300 [thread overview]
Message-ID: <20161006202944.GH4809@kernel.org> (raw)
In-Reply-To: <20161006200839.GD3078@tassilo.jf.intel.com>
Em Thu, Oct 06, 2016 at 01:08:39PM -0700, Andi Kleen escreveu:
> > perf stat -e CPL_CYCLES.RING0
> >
> > but if I try:
> >
> > perf stat -e cycles,CPL<TAB>
> >
> > I get nothing :-\
> >
> > Is this working with you?
>
> You can't mix cases like this, the upper case patch doesn't support that.
> It's either all upper or all lower case.
>
> If you continue with lower case it should work.
I understand that this should be a limitation of the current patch, but
if we decide to support completion after a comma, I think people will
expect that all events will be available :-\
- Arnaldo
next prev parent reply other threads:[~2016-10-06 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 19:23 [PATCH 1/3] perf, tools: Add support for perf list json Andi Kleen
2016-10-06 19:23 ` [PATCH 2/3] perf, tools: Handle completion of upper case events Andi Kleen
2016-10-06 20:05 ` Arnaldo Carvalho de Melo
2016-10-06 19:23 ` [PATCH 3/3] perf, tools: Fix completion script to handle comma list Andi Kleen
2016-10-06 20:05 ` Arnaldo Carvalho de Melo
2016-10-06 20:08 ` Andi Kleen
2016-10-06 20:29 ` Arnaldo Carvalho de Melo [this message]
2016-10-06 20:41 ` Andi Kleen
2016-10-06 20:05 ` [PATCH 1/3] perf, tools: Add support for perf list json Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2016-10-18 23:20 [PATCH 1/3] perf, tools: Add support for perf list vendor Andi Kleen
2016-10-18 23:21 ` [PATCH 3/3] perf, tools: Fix completion script to handle comma list Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006202944.GH4809@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).