From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754815AbcJFWBC (ORCPT ); Thu, 6 Oct 2016 18:01:02 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:60002 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbcJFWAx (ORCPT ); Thu, 6 Oct 2016 18:00:53 -0400 Date: Thu, 6 Oct 2016 23:00:51 +0100 From: Al Viro To: Sinan Kaya Cc: timur@codeaurora.org, cov@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Message-ID: <20161006220050.GN19539@ZenIV.linux.org.uk> References: <1475789429-11414-1-git-send-email-okaya@codeaurora.org> <20161006213734.GM19539@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 06, 2016 at 05:41:34PM -0400, Sinan Kaya wrote: > On 10/6/2016 5:37 PM, Al Viro wrote: > > On Thu, Oct 06, 2016 at 05:30:29PM -0400, Sinan Kaya wrote: > >> This reverts commit acc29fb8f792 ("debugfs: ->d_parent is never NULL or > >> negative") as it breaks the debugfs_remove_recursive API as show in the > >> callstack below. > > > > NAK. Fix your code, don't break global asserts. > > > > I can fix the code if you tell me what the problem is: Getting dentries with NULL ->d_parent should never, ever happen. Find the place where such a beast appears and you've got your problem. The same goes for negative dentries with children. Again, if your code triggers such a situation, find where it does so and you've found a bug. More than one, at that.