From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756337AbcJGNHe (ORCPT ); Fri, 7 Oct 2016 09:07:34 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59813 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751264AbcJGNHZ (ORCPT ); Fri, 7 Oct 2016 09:07:25 -0400 Date: Fri, 7 Oct 2016 10:38:53 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Message-ID: <20161007083853.GH4684@lukather> References: <20161006160629.11198-1-wens@csie.org> <20161006160629.11198-3-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtJ+CqYNzKB4ukR4" Content-Disposition: inline In-Reply-To: <20161006160629.11198-3-wens@csie.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vtJ+CqYNzKB4ukR4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote: > +struct sun4i_tcon_quirks { > + bool is_sun5i; /* sun5i has undocumented mux */ > + bool has_channel_1; /* a33 does not have channel 1 */ > + bool has_bypass_src; /* has separate input bypassing CEU */ > + bool has_dma_src; /* has DMA input */ > +}; > + I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't really relate to what we're doing there, is redundant with the compatible, and render the other quirks name useless, since we could just have is_sun.i quirks and deal with that (which is essentially what we were doing before). Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --vtJ+CqYNzKB4ukR4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX918dAAoJEBx+YmzsjxAgeH4QAJw9YrSPeE9XtsL1yWEnBbHT 8RkrE7sKzRYtp6hLyfRIYsFQA5BR7EqYBD1Es5WLfWphQcNMdPs91KT4HcxNPILc il462QVzoSvjMOhEhNA2YyJ302Wu+7xZ1Sqxk5PK1uswCWEs+wend2uP6z2O+47K Qu0eI/92SkXu6X2+z/xGw5isKMMexJ/t2wx3NrTyLYa9YHhGuPAtzP1UFOuZFsQS svpikvv1akInCg5kS46gkGk5+wvgj8NW79rFLQ8S3/YL4BT/0Ac6uCjAkDFv/jOd MwKcJISQHogYojc62SAe16UuDaBZUA+FiWg70ENvfDPWa6J9mUVTXkKJr2sZTH63 xxUnT0OpL4XMhcacYNO3Z/3JekapDOntbm/HFnKbBU5XdWm2EP9GSHiypNM0JncV nTTZwqbuSv2Y7tw+bHLF0nl0a135w+1UR8B6mfRU52dRJ1dlSynHh0iBS3i0t9Cb BIKFVT0T/l96NoXNQTn5OSpHAGgbJumGp7lLvVCOkc1QtIimWOHxmPz8MIzcsc6C jw5dqMiAGMsf7sYTkSRf9XRR5UFvHu8w3yZsI33rrU8q+6JvPkcwwU/WPl89SXZv fAvV61bSPFqmMdGfAgpSDmvxZ/vhCXhsoOAZLSXFHNLtv7JBXzjtPrv0jvg1nxHz 221FgzBlj3o8M+2k2Vhb =DSUx -----END PGP SIGNATURE----- --vtJ+CqYNzKB4ukR4--