From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756546AbcJGNIO (ORCPT ); Fri, 7 Oct 2016 09:08:14 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59836 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756391AbcJGNHs (ORCPT ); Fri, 7 Oct 2016 09:07:48 -0400 Date: Fri, 7 Oct 2016 10:55:28 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 4/9] drm/sun4i: Add compatible string for A31/A31s TCON (timing controller) Message-ID: <20161007085528.GJ4684@lukather> References: <20161006160629.11198-1-wens@csie.org> <20161006160629.11198-5-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="07FIeBX8hApXX6Bi" Content-Disposition: inline In-Reply-To: <20161006160629.11198-5-wens@csie.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --07FIeBX8hApXX6Bi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Oct 07, 2016 at 12:06:24AM +0800, Chen-Yu Tsai wrote: > The A31 TCON has mux controls for how TCON outputs are routed to the > HDMI and MIPI DSI blocks. >=20 > Since the A31s does not have MIPI DSI, it only has a mux for the HDMI > controller input. >=20 > This patch only adds support for the compatible strings. Actual support > for the mux controls should be added with HDMI and MIPI DSI support. Then let's add those fields then, having dead code and useless variables is never a good option :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --07FIeBX8hApXX6Bi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX92MAAAoJEBx+YmzsjxAgUoUP/Ro5kjUIdcz5USYjmZO4safZ +Dw7l8FCH5Z9SxDOEFmBbizyJpizsB8qZlRdNtmztvwF2qD5rAMGLrey7FGpF0lg gxB38oEjL8mTUyAWRIuCny2+N2O9AzQoWd+FyhQPzH9sh1R4G87IT9+w+lJDy0n0 Whm+SUvbYrBuiIfUrZuMsKmcpU/eTO/AWxZTtKPWKLG8F3HBrkCHg0/2Ha6R5441 85SmYZjLAX8vj2nBErjhLgeKozLVJOkLOMkqteb6YXKs40cjmZlCZ0goH628a4nB XAvpisBPBR+Hywb/DFN87a10nVnUozdJ5GrkxknnN4geOPVWwJrKdeaYa2pAGxxq wrpd8WkhmflnmGSGzpV0acE/2p+JsHt6An4Z2P48FNhLBNhN1uv6zwxiQtYnGg7N YyksDxxaO7qbvzgr0/k4SeygjVuAI95i2RShFhUQDDeCQarQOhXeiyYUFhnYUSCN DOIXx40oXQ4fNcDvixNybzX8Vld1QaCGZsAeuJgp2fuc6M36nEGa1SAVBZOZnxwb lDOi6GaTv4rqRYiqRNjYcDltTC8KnmJd7LrhLB1++k9zxRdAjPa0dZERfL5gx780 uKK5Ip1x7DCe7jV8vojfOvWm1B5ZI7A70TNNeMP56jTZtpq/zREITPfw0IcqQoME o7gtY98GaI2GwkH308OX =owpr -----END PGP SIGNATURE----- --07FIeBX8hApXX6Bi--