From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756550AbcJGOHJ (ORCPT ); Fri, 7 Oct 2016 10:07:09 -0400 Received: from smtprelay0201.hostedemail.com ([216.40.44.201]:40332 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755194AbcJGOHD (ORCPT ); Fri, 7 Oct 2016 10:07:03 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3872:5007:6261:7875:8531:10004:10400:10848:10967:11026:11232:11658:11914:12114:12296:12438:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:6,LUA_SUMMARY:none X-HE-Tag: cause55_202719c06984e X-Filterd-Recvd-Size: 1444 Date: Fri, 7 Oct 2016 10:06:59 -0400 From: Steven Rostedt To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Message-ID: <20161007100659.7ac3313e@gandalf.local.home> In-Reply-To: <20161007041907.GC31113@sejong> References: <20161001101700.29146-1-namhyung@kernel.org> <20161005092801.3a8e9166@gandalf.local.home> <20161007041907.GC31113@sejong> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Oct 2016 13:19:08 +0900 Namhyung Kim wrote: > Actually kbuffer_load_subbuffer() calls kbuf->next_event(). Inside > the function it has a loop updating next valid event. Sometimes, the > data starts with TIME_EXTEND with value of 0 and the loop skips it > which ended up setting kbuf->curr to 8. :) Right, because kbuffer_read_at_offset() should not return a TIME_EXTEND. -- Steve