From: Pavel Machek <pavel@ucw.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Johan Hovold <johan@hovoldconsulting.com>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sandeep Patil <sspatil@google.com>,
Matt Porter <mporter@kernel.crashing.org>,
John Stultz <john.stultz@linaro.org>,
Rob Herring <robh@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Alex Elder <elder@linaro.org>, David Lin <dtwlin@google.com>,
"Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
Vaibhav Agarwal <vaibhav.agarwal@linaro.org>,
Mark Greer <mgreer@animalcreek.com>
Subject: Re: [patch 12/32] greybus: es2 host driver
Date: Fri, 7 Oct 2016 15:43:14 +0200 [thread overview]
Message-ID: <20161007134314.GB19976@amd> (raw)
In-Reply-To: <20160916132525.GJ31174@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On Fri 2016-09-16 15:25:25, Greg KH wrote:
> This is a Greybus host driver for the ES2/3 bridge chip from Toshiba.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> +/*
> + * @endpoint: bulk in endpoint for CPort data
> + * @urb: array of urbs for the CPort in messages
> + * @buffer: array of buffers for the @cport_in_urb urbs
> + */
> +struct es2_cport_in {
> + __u8 endpoint;
> + struct urb *urb[NUM_CPORT_IN_URB];
> + u8 *buffer[NUM_CPORT_IN_URB];
Underscored versions of __u8 and friends are unneccessary here... as
shown later in the struct. Makes sense to fix in whole file.
pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-10-07 13:43 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:09 [GIT PULL] Greybus driver subsystem for 4.9-rc1 Greg KH
2016-09-14 17:36 ` Mark Rutland
2016-09-14 18:07 ` Greg KH
2016-09-14 18:29 ` Greg KH
2016-09-14 19:05 ` Joe Perches
2016-09-15 9:35 ` Bryan O'Donoghue
2016-09-15 10:13 ` Mark Rutland
2016-09-15 10:35 ` Bryan O'Donoghue
2016-09-15 10:47 ` Bryan O'Donoghue
2016-09-15 11:20 ` Mark Rutland
2016-09-15 11:48 ` Bryan O'Donoghue
2016-09-15 12:46 ` Mark Rutland
2016-09-15 15:40 ` Bryan O'Donoghue
2016-09-15 15:47 ` Mark Rutland
2016-09-15 16:09 ` Bryan O'Donoghue
2016-09-14 20:07 ` Rob Herring
2016-09-15 10:17 ` Greg KH
2016-09-15 11:02 ` Bryan O'Donoghue
[not found] ` <20160915122141.650632149@bubbles.kroah.org>
[not found] ` <20160915122234.640367870@bubbles.kroah.org>
2016-09-15 13:16 ` [patch 11/32] greybus: camera driver Laurent Pinchart
2016-09-15 14:45 ` [GIT PULL] Greybus driver subsystem for 4.9-rc1 Mark Brown
2016-09-16 6:05 ` Greg KH
2016-09-16 10:18 ` Mark Brown
2016-09-16 13:22 ` Greg KH
2016-09-16 14:24 ` Greg KH
2016-09-20 6:41 ` Greg KH
2016-09-20 7:12 ` Vaibhav Agarwal
2016-09-16 12:18 ` Arnd Bergmann
2016-09-21 13:02 ` Mark Rutland
2016-09-21 14:13 ` Greg KH
2016-09-16 6:40 ` [patch 00/32] Greybus driver subsystem Greg KH
2016-09-16 6:41 ` [patch 02/32] greybus: interface control logic Greg KH
2016-09-16 13:22 ` [patch 03/32] greybus: operations logic Greg KH
2016-09-16 13:23 ` [patch 04/32] greybus: host driver framework Greg KH
2016-09-16 13:23 ` [patch 05/32] greybus: trace.h Greg KH
2016-09-16 13:23 ` [patch 06/32] greybus: svc driver/watchdog Greg KH
2016-09-16 13:23 ` [patch 07/32] greybus: core code Greg KH
2016-09-16 13:24 ` [patch 08/32] greybus: bootrom driver Greg KH
2016-09-16 13:24 ` [patch 09/32] greybus: firmware download class driver Greg KH
2016-09-16 13:24 ` [patch 10/32] greybus: audio driver Greg KH
2016-09-16 13:25 ` [patch 11/32] greybus: camera driver Greg KH
2016-09-16 13:25 ` [patch 12/32] greybus: es2 host driver Greg KH
2016-10-07 13:43 ` Pavel Machek [this message]
2016-09-16 14:09 ` [patch 13/32] greybus: HID driver Greg KH
2016-09-16 14:10 ` [patch 14/32] greybus: LED driver Greg KH
2016-10-07 13:36 ` Pavel Machek
2016-10-07 13:41 ` Greg KH
2016-09-16 14:10 ` [patch 15/32] greybus: logging driver Greg KH
2016-09-16 14:10 ` [patch 16/32] greybus: loopback driver Greg KH
2016-09-16 14:10 ` [patch 17/32] greybus: power supply driver Greg KH
2016-10-07 13:49 ` Pavel Machek
2016-10-07 14:12 ` Greg KH
2016-10-07 18:15 ` Pavel Machek
2016-09-16 14:11 ` [patch 18/32] greybus: raw driver Greg KH
2016-09-16 14:11 ` [patch 19/32] greybus: timesync driver Greg KH
2016-09-16 14:11 ` [patch 20/32] greybus: vibrator driver Greg KH
2016-09-16 14:19 ` [patch 21/32] greybus: arche platform driver Greg KH
2016-09-16 14:20 ` [patch 22/32] greybus: bridged phy bus code Greg KH
2016-09-16 14:20 ` [patch 23/32] greybus: bridged phy gpio driver Greg KH
2016-09-16 14:20 ` [patch 24/32] greybus: bridged phy i2c driver Greg KH
2016-09-16 14:20 ` [patch 25/32] greybus: bridged phy pwm driver Greg KH
2016-09-16 14:21 ` [patch 26/32] greybus: bridged phy sdio driver Greg KH
2016-09-16 14:21 ` [patch 27/32] greybus: bridged phy spi driver Greg KH
2016-09-16 14:21 ` [patch 28/32] greybus: bridged phy uart driver Greg KH
2016-09-16 14:21 ` [patch 29/32] greybus: bridged phy usb driver Greg KH
2016-09-16 14:22 ` [patch 30/32] greybus: tools Greg KH
2016-09-16 14:22 ` [patch 31/32] greybus: documentation Greg KH
2016-09-16 14:22 ` [patch 32/32] greybus: add to the build Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007134314.GB19976@amd \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=dtwlin@google.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@hovoldconsulting.com \
--cc=john.stultz@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=mporter@kernel.crashing.org \
--cc=pure.logic@nexus-software.ie \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
--cc=sspatil@google.com \
--cc=vaibhav.agarwal@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).