From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756580AbcJGNnW (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Oct 2016 09:43:22 -0400
Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49256 "EHLO
        atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752298AbcJGNnR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Oct 2016 09:43:17 -0400
Date: Fri, 7 Oct 2016 15:43:14 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        Johan Hovold <johan@hovoldconsulting.com>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sandeep Patil <sspatil@google.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        John Stultz <john.stultz@linaro.org>, Rob Herring <robh@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, Alex Elder <elder@linaro.org>,
        David Lin <dtwlin@google.com>,
        "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Vaibhav Agarwal <vaibhav.agarwal@linaro.org>,
        Mark Greer <mgreer@animalcreek.com>
Subject: Re: [patch 12/32] greybus: es2 host driver
Message-ID: <20161007134314.GB19976@amd>
References: <20160914100949.GA6179@kroah.com>
 <20160916064058.GA17821@kroah.com>
 <20160916132525.GJ31174@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="Fba/0zbH8Xs+Fj9o"
Content-Disposition: inline
In-Reply-To: <20160916132525.GJ31174@kroah.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--Fba/0zbH8Xs+Fj9o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri 2016-09-16 15:25:25, Greg KH wrote:
> This is a Greybus host driver for the ES2/3 bridge chip from Toshiba.
>=20
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---

> +/*
> + * @endpoint: bulk in endpoint for CPort data
> + * @urb: array of urbs for the CPort in messages
> + * @buffer: array of buffers for the @cport_in_urb urbs
> + */
> +struct es2_cport_in {
> +	__u8 endpoint;
> +	struct urb *urb[NUM_CPORT_IN_URB];
> +	u8 *buffer[NUM_CPORT_IN_URB];

Underscored versions of __u8 and friends are unneccessary here... as
shown later in the struct. Makes sense to fix in whole file.
								pavel


--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--Fba/0zbH8Xs+Fj9o
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlf3pnIACgkQMOfwapXb+vKnvQCeNBtdAny+erMgMzyrUiDLufP4
F9oAn0xQ5qzJ52mzY4RT3DmZ+0adm/aW
=ZViW
-----END PGP SIGNATURE-----

--Fba/0zbH8Xs+Fj9o--