From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756329AbcJGJEG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Oct 2016 05:04:06 -0400
Received: from mail.kernel.org ([198.145.29.136]:55578 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752681AbcJGJD6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Oct 2016 05:03:58 -0400
Date: Fri, 7 Oct 2016 18:03:51 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH] ftrace: Support full glob matching
Message-Id: <20161007180351.db6e9ca74c4e779c12e30d3f@kernel.org>
In-Reply-To: <20161005093635.3c9360ca@gandalf.local.home>
References: <147566869501.29136.6462645009894738056.stgit@devbox>
        <20161005093635.3c9360ca@gandalf.local.home>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 5 Oct 2016 09:36:35 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed,  5 Oct 2016 20:58:15 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > Use glob_match() to support flexible glob wildcards (*,?)
> > and character classes ([) for ftrace.
> > Since the full glob matching is slower than the current
> > partial matching routines(*pat, pat*, *pat*), this leaves
> > those routines and just add MATCH_GLOB for complex glob
> > expression.
> > 
> > e.g.
> > ----
> > [root@localhost tracing]# echo 'sched*group' > set_ftrace_filter
> > [root@localhost tracing]# cat set_ftrace_filter
> > sched_free_group
> > sched_change_group
> > sched_create_group
> > sched_online_group
> > sched_destroy_group
> > sched_offline_group
> > [root@localhost tracing]# echo '[Ss]y[Ss]_*' > set_ftrace_filter
> > [root@localhost tracing]# head set_ftrace_filter
> > sys_arch_prctl
> > sys_rt_sigreturn
> > sys_ioperm
> > SyS_iopl
> > sys_modify_ldt
> > SyS_mmap
> > SyS_set_thread_area
> > SyS_get_thread_area
> > SyS_set_tid_address
> > sys_fork
> > ----
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Nice! Although, I probably wont get to look at this till I get back
> from Berlin. Please send me a friendly "ping" on the 17th.

OK, I'm also considering update ftracetest too for recent features.
Maybe I would better make a series including this.

> I'll still add it to my new "todo" folder. Since, just marking patches
> in my inbox as todo hasn't been working out for me, I've created a
> separate folder for ftrace patches.

:)

Thanks!

> 
> Thanks!
> 
> -- Steve


-- 
Masami Hiramatsu <mhiramat@kernel.org>