From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751947AbcJJBT4 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 9 Oct 2016 21:19:56 -0400
Received: from mail-pa0-f68.google.com ([209.85.220.68]:33033 "EHLO
        mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751110AbcJJBTz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 9 Oct 2016 21:19:55 -0400
Date: Sat, 8 Oct 2016 03:56:33 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Jan Kara <jack@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        Tejun Heo <tj@kernel.org>, Calvin Owens <calvinowens@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mel Gorman <mgorman@techsingularity.net>,
        Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv2 0/7] printk: use alt_printk to handle printk()
 recursive calls
Message-ID: <20161007185633.GB486@swordfish>
References: <20160930151758.8965-1-sergey.senozhatsky@gmail.com>
 <20161006155506.GK13369@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161006155506.GK13369@pathway.suse.cz>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (10/06/16 17:55), Petr Mladek wrote:
> On Sat 2016-10-01 00:17:51, Sergey Senozhatsky wrote:
> > Hello,
> > 
> >         RFC
> > 
> >         This patch set extends a lock-less NMI per-cpu buffers idea to
> > handle recursive printk() calls. The basic mechanism is pretty much the
> > same -- at the beginning of a deadlock-prone section we switch to lock-less
> > printk callback, and return back to a default printk implementation at the
> > end; the messages are getting flushed to a logbuf buffer from a safer
> > context.
> 
> OK, I think again that this patch set makes sense. It looks good after
> all my doubts ;-)
> 
> Just I would like you to consider using some more meaningful name
> instead of the "alt" prefix. I wonder how the following prefix
> would look like:
> 
> 	printk_safe*
> 	printk_safe_nmi*

sure. I want to rename it. not entirely sure that printk_safe_enter()
is the best option here, but I can't think of anything better.

> prefix rather than a suffix.

good point. will change to 'suffix'.

> Also "alt_printk_ctx" per-CPU variable describes a global
> printk state. I think that the alt_ prefix is not needed
> and "printk_context" would be better readable.

yep, will do. thanks.

	-ss