From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849AbcJIBab (ORCPT ); Sat, 8 Oct 2016 21:30:31 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36442 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbcJIBa3 (ORCPT ); Sat, 8 Oct 2016 21:30:29 -0400 Date: Sat, 8 Oct 2016 20:28:18 -0500 From: Rob Herring To: Zhao Qiang Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, xiaobo.xie@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] bindings: add compatible "fsl, ls1043-ucc-hdlc" to bindings Message-ID: <20161009012818.GA18158@rob-hp-laptop> References: <1475034038-7217-1-git-send-email-qiang.zhao@nxp.com> <1475034038-7217-3-git-send-email-qiang.zhao@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475034038-7217-3-git-send-email-qiang.zhao@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2016 at 11:40:38AM +0800, Zhao Qiang wrote: > Signed-off-by: Zhao Qiang > --- > Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt > index 03c7416..325e3e2 100644 > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt > @@ -45,7 +45,7 @@ Example: > * HDLC > > Currently defined compatibles: > -- fsl,ucc-hdlc > +- "fsl,ucc-hdlc", "fsl,ls1043-ucc-hdlc" What's the relationship of these 2 compatibles? Both should be specified for LS1043 or ...? The former only applies to certain SoCs? Rework this text to answer these questions. Rob