* [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues
@ 2016-10-07 2:38 Chase Metzger
2016-10-07 3:24 ` Viresh Kumar
2016-10-07 3:45 ` Vaibhav Agarwal
0 siblings, 2 replies; 5+ messages in thread
From: Chase Metzger @ 2016-10-07 2:38 UTC (permalink / raw)
To: vaibhav.sr
Cc: mgreer, johan, elder, gregkh, devel, linux-kernel, Chase Metzger
Added braces to else statements where checkpatch complained.
Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
---
drivers/staging/greybus/audio_topology.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
index b625169..3a2678e 100644
--- a/drivers/staging/greybus/audio_topology.c
+++ b/drivers/staging/greybus/audio_topology.c
@@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
- } else
+ } else {
csize = sizeof(struct gb_audio_control);
+ }
+
*w_size += csize;
curr = (void *)curr + csize;
list_add(&control->list, &module->widget_ctl_list);
@@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module,
control->texts = (const char * const *)
gb_generate_enum_strings(module, gbenum);
control->items = gbenum->items;
- } else
+ } else {
csize = sizeof(struct gb_audio_control);
+ }
list_add(&control->list, &module->ctl_list);
dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues
2016-10-07 2:38 Chase Metzger
@ 2016-10-07 3:24 ` Viresh Kumar
2016-10-07 3:45 ` Vaibhav Agarwal
1 sibling, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2016-10-07 3:24 UTC (permalink / raw)
To: Chase Metzger
Cc: Vaibhav Agarwal, driver-dev, Alex Elder, Greg Kroah-Hartman,
mgreer, linux-kernel@vger.kernel.org, Johan Hovold
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger <chasemetzger15@gmail.com> wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/staging/greybus/audio_topology.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues
2016-10-07 2:38 Chase Metzger
2016-10-07 3:24 ` Viresh Kumar
@ 2016-10-07 3:45 ` Vaibhav Agarwal
1 sibling, 0 replies; 5+ messages in thread
From: Vaibhav Agarwal @ 2016-10-07 3:45 UTC (permalink / raw)
To: Chase Metzger
Cc: Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel,
linux-kernel
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger <chasemetzger15@gmail.com> wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues
@ 2016-10-08 0:04 Chase Metzger
2016-10-09 14:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Chase Metzger @ 2016-10-08 0:04 UTC (permalink / raw)
To: vaibhav.sr
Cc: Chase Metzger, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, devel, linux-kernel
Added braces to else statements where checkpatch complained.
Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 8a0744b..1bdf849 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
ret = gb_audio_apbridgea_shutdown_rx(data->connection,
0);
params->state = GBAUDIO_CODEC_STOP;
- } else
+ } else {
ret = -EINVAL;
+ }
+
if (ret)
dev_err_ratelimited(dai->dev,
"%s:Error during %s %s stream:%d\n",
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues
2016-10-08 0:04 [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues Chase Metzger
@ 2016-10-09 14:03 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-10-09 14:03 UTC (permalink / raw)
To: Chase Metzger
Cc: vaibhav.sr, devel, Alex Elder, Johan Hovold, Mark Greer,
linux-kernel
On Fri, Oct 07, 2016 at 05:04:16PM -0700, Chase Metzger wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
You used the same subject here as your last patch, which implies it did
the same thing, yet it did not :(
So please make the subject unique.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-09 14:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-08 0:04 [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues Chase Metzger
2016-10-09 14:03 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2016-10-07 2:38 Chase Metzger
2016-10-07 3:24 ` Viresh Kumar
2016-10-07 3:45 ` Vaibhav Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox